From: Dangyi Liu <dliu@redhat.com>
To: Dave Young <dyoung@redhat.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] vmcore-dmesg: do not use logged_chars as dmesg length
Date: Wed, 28 Oct 2015 15:34:58 +0800 [thread overview]
Message-ID: <1446017698.3618.0.camel@redhat.com> (raw)
In-Reply-To: <20151028070618.GD30645@dhcp-128-73.nay.redhat.com>
On Wed, 2015-10-28 at 15:06 +0800, Dave Young wrote:
> Please use /* */ style comment, also it is not a bug because
> In theroy it is ok for only showing later dmesg after dmesg -c in
> current code.
> But crash utils and vmcore-dmesg in new log buf format support
> dumping all
> kernel messages which includes the part before dmesg -c. It is not
> harm to
> keep same behavior with them.
>
> So the comment should be changed to something like below:
> /*
> * To collect full dmesg including the part before `dmesg -c` is
> useful for
> * later debugging. Use same logic as what crash utility is using.
> */
OK, I'll update the comment and send again.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2015-10-28 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 5:38 [PATCH] vmcore-dmesg: do not use logged_chars as dmesg length Dangyi Liu
2015-10-28 7:06 ` Dave Young
2015-10-28 7:34 ` Dangyi Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446017698.3618.0.camel@redhat.com \
--to=dliu@redhat.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox