From: Andrew Jones <drjones@redhat.com>
To: kexec@lists.infradead.org
Subject: [PATCH 4/4] kexec/fs2dt: check for /chosen/stdout-path first
Date: Fri, 20 Nov 2015 12:31:54 -0500 [thread overview]
Message-ID: <1448040714-19841-5-git-send-email-drjones@redhat.com> (raw)
In-Reply-To: <1448040714-19841-1-git-send-email-drjones@redhat.com>
Check /chosen/stdout-path first, as linux,stdout-path is deprecated.
I don't know how the ppc64:my_debug thing works, but on arm the warning
"Unable to find /proc/device-tree//chosen/linux,stdout-path, printing
from purgatory is diabled" is output when loading a kexec kernel. This
patch at least suppresses that when /chosen/stdout-path exists, and
maybe it even enables printing from purgatory?
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
kexec/fs2dt.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/kexec/fs2dt.c b/kexec/fs2dt.c
index affee57b9bb62..b3c209b871a15 100644
--- a/kexec/fs2dt.c
+++ b/kexec/fs2dt.c
@@ -656,12 +656,16 @@ static void putnode(void)
* code can print 'I'm in purgatory' message. Currently only
* pseries/hvcterminal is supported.
*/
- snprintf(filename, MAXPATH, "%slinux,stdout-path", pathname);
+ snprintf(filename, MAXPATH, "%sstdout-path", pathname);
fd = open(filename, O_RDONLY);
if (fd == -1) {
- printf("Unable to find %s, printing from purgatory is disabled\n",
- filename);
- goto no_debug;
+ snprintf(filename, MAXPATH, "%slinux,stdout-path", pathname);
+ fd = open(filename, O_RDONLY);
+ if (fd == -1) {
+ printf("Unable to find %s[linux,]stdout-path, printing from purgatory is disabled\n",
+ pathname);
+ goto no_debug;
+ }
}
if (fstat(fd, &statbuf)) {
printf("Unable to stat %s, printing from purgatory is disabled\n",
--
2.4.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-11-20 17:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 17:31 [PATCH 0/4] [RFT] cleanup /chosen/linux,stdout-path warning Andrew Jones
2015-11-20 17:31 ` [PATCH 1/4] uImage: cleanup some warnings Andrew Jones
2015-11-24 7:00 ` Simon Horman
2015-11-25 17:32 ` Andrew Jones
2015-11-20 17:31 ` [PATCH 2/4] kexec/fs2dt: s/diabled/disabled/ Andrew Jones
2015-11-24 7:00 ` Simon Horman
2015-11-20 17:31 ` [PATCH 3/4] kexec/fs2dt: cleanup pathname Andrew Jones
2015-11-24 7:01 ` Simon Horman
2015-11-20 17:31 ` Andrew Jones [this message]
2015-11-24 7:03 ` [PATCH 4/4] kexec/fs2dt: check for /chosen/stdout-path first Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448040714-19841-5-git-send-email-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox