Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Curt Brune <curt@cumulusnetworks.com>
To: kexec@lists.infradead.org
Subject: [PATCH 0/1] Improve device tree directory sorting
Date: Tue, 24 Nov 2015 18:17:09 -0800	[thread overview]
Message-ID: <1448417830-48786-1-git-send-email-curt@cumulusnetworks.com> (raw)

This patch improves the device tree directory sorting.

Previously the sorting algorithm would result in the following ordering for a
Freescale P2020 SoC device (Rooted under: /proc/device-tree/soc@ffe00000)

  #address-cells
  #size-cells
  .
  ..
  bus-frequency
  compatible
  device_type
  i2c@3000
  i2c@3100
  mdio@24520
  msi@41600
  mdio@26520
  serial@4600
  ethernet@26000
  global-utilities@e0000
  memory-controller@2000
  l2-cache-controller@20000
  name
  pic@40000
  ranges
  sdhci@2e000
  serial@4500

Ideally 'serial@4500' would come before 'serial@4600'.  This would
cause the new kexec-ed kernel to have the serial consoles detected in
the wrong order, i.e. ttyS0 and ttyS1 are swapped.  

Using the attached patch the same directory is ordered as:

  #address-cells
  #size-cells
  .
  ..
  bus-frequency
  compatible
  device_type
  ethernet@26000
  global-utilities@e0000
  i2c@3000
  i2c@3100
  l2-cache-controller@20000
  mdio@24520
  mdio@26520
  memory-controller@2000
  msi@41600
  name
  pic@40000
  ranges
  sdhci@2e000
  serial@4500
  serial@4600

Curt Brune (1):
  Improve device tree directory sorting

 kexec/arch/ppc/fs2dt.c | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

-- 
1.9.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

                 reply	other threads:[~2015-11-25  2:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448417830-48786-1-git-send-email-curt@cumulusnetworks.com \
    --to=curt@cumulusnetworks.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox