From: Baoquan He <bhe@redhat.com>
To: joro@8bytes.org
Cc: Baoquan He <bhe@redhat.com>,
kexec@lists.infradead.org, xlpang@redhat.com,
linux-kernel@vger.kernel.org, Vincent.Wan@amd.com,
iommu@lists.linux-foundation.org, dyoung@redhat.com
Subject: [PATCH v5 4/8] iommu/amd: Add function copy_dev_tables
Date: Thu, 15 Sep 2016 23:03:22 +0800 [thread overview]
Message-ID: <1473951806-25511-5-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1473951806-25511-1-git-send-email-bhe@redhat.com>
Add function copy_dev_tables to copy the old DEV table entry of the panicked
kernel to the new allocated DEV table. Since all iommu share the same DTE table
the copy only need be done once as long as the physical address of old DEV table
is retrieved from iommu reg. Besides the old domain id occupied in 1st kernel
need be reserved to avoid touching the old io-page tables so that on-flight DMA
can continue looking up.
And define MACRO DEV_DOMID_MASK to replace magic number 0xffffULL because
it need be reused in copy_dev_tables.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
drivers/iommu/amd_iommu.c | 2 +-
drivers/iommu/amd_iommu_init.c | 40 ++++++++++++++++++++++++++++++++++++++++
drivers/iommu/amd_iommu_types.h | 1 +
3 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 995b050..fcb69ff 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -1747,7 +1747,7 @@ static void set_dte_entry(u16 devid, struct protection_domain *domain, bool ats)
flags |= tmp;
}
- flags &= ~(0xffffUL);
+ flags &= ~DEV_DOMID_MASK;
flags |= domain->id;
amd_iommu_dev_table[devid].data[1] = flags;
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index 77c44c8..ce49641 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -717,6 +717,46 @@ static int get_dev_entry_bit(u16 devid, u8 bit)
}
+static int copy_dev_tables(void)
+{
+ u64 entry;
+ u32 lo, hi, devid;
+ phys_addr_t old_devtb_phys;
+ struct dev_table_entry *old_devtb = NULL;
+ u16 dom_id, dte_v;
+ struct amd_iommu *iommu;
+ static int copied;
+
+ for_each_iommu(iommu) {
+ if (!translation_pre_enabled(iommu)) {
+ pr_err("IOMMU:%d is not pre-enabled!/n", iommu->index);
+ return -1;
+ }
+
+ if (copied)
+ continue;
+
+ lo = readl(iommu->mmio_base + MMIO_DEV_TABLE_OFFSET);
+ hi = readl(iommu->mmio_base + MMIO_DEV_TABLE_OFFSET + 4);
+ entry = (((u64) hi) << 32) + lo;
+ old_devtb_phys = entry & PAGE_MASK;
+ old_devtb = memremap(old_devtb_phys, dev_table_size, MEMREMAP_WB);
+ if (!old_devtb)
+ return -1;
+ for (devid = 0; devid <= amd_iommu_last_bdf; ++devid) {
+ amd_iommu_dev_table[devid] = old_devtb[devid];
+ dom_id = amd_iommu_dev_table[devid].data[1] & DEV_DOMID_MASK;
+ dte_v = amd_iommu_dev_table[devid].data[0] & DTE_FLAG_V;
+ if (!dte_v || !dom_id)
+ continue;
+ __set_bit(dom_id, amd_iommu_pd_alloc_bitmap);
+ }
+ memunmap(old_devtb);
+ copied = 1;
+ }
+ return 0;
+}
+
void amd_iommu_apply_erratum_63(u16 devid)
{
int sysmgt;
diff --git a/drivers/iommu/amd_iommu_types.h b/drivers/iommu/amd_iommu_types.h
index 809944a..a1ccede 100644
--- a/drivers/iommu/amd_iommu_types.h
+++ b/drivers/iommu/amd_iommu_types.h
@@ -310,6 +310,7 @@
#define DTE_FLAG_MASK (0x3ffULL << 32)
#define DTE_GLX_SHIFT (56)
#define DTE_GLX_MASK (3)
+#define DEV_DOMID_MASK 0xffffULL
#define DTE_GCR3_VAL_A(x) (((x) >> 12) & 0x00007ULL)
#define DTE_GCR3_VAL_B(x) (((x) >> 15) & 0x0ffffULL)
--
2.5.5
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-09-15 15:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 15:03 [PATCH v5 0/8] Fix kdump faults on system with amd iommu Baoquan He
2016-09-15 15:03 ` [PATCH v5 1/8] iommu/amd: Detect pre enabled translation Baoquan He
2016-09-15 15:03 ` [PATCH v5 2/8] iommu/amd: add early_enable_iommu() wrapper function Baoquan He
2016-09-15 15:03 ` [PATCH v5 3/8] iommu/amd: Define bit fields for DTE particularly Baoquan He
2016-09-15 15:03 ` Baoquan He [this message]
[not found] ` <20160920115804.GC3541@8bytes.org>
2016-09-21 10:17 ` [PATCH v5 4/8] iommu/amd: Add function copy_dev_tables Baoquan He
2016-09-15 15:03 ` [PATCH v5 5/8] iommu/amd: copy old trans table from old kernel Baoquan He
[not found] ` <20160920124031.GD3541@8bytes.org>
2016-09-21 10:18 ` Baoquan He
2016-09-28 1:37 ` Baoquan He
2016-09-28 13:01 ` Baoquan He
2016-09-15 15:03 ` [PATCH v5 6/8] iommu/amd: Do not re-enable dev table entries in kdump Baoquan He
[not found] ` <20160920124241.GE3541@8bytes.org>
2016-09-21 10:20 ` Baoquan He
2016-09-15 15:03 ` [PATCH v5 7/8] iommu/amd: Don't update domain info to dte entry at iommu init stage Baoquan He
[not found] ` <20160920125004.GF3541@8bytes.org>
2016-09-21 10:26 ` Baoquan He
2016-09-21 13:21 ` Baoquan He
2016-09-15 15:03 ` [PATCH v5 8/8] iommu/amd: Update domain into to dte entry during device driver init Baoquan He
[not found] ` <20160920125330.GG3541@8bytes.org>
2016-09-21 10:31 ` Baoquan He
2016-09-27 1:51 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473951806-25511-5-git-send-email-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=Vincent.Wan@amd.com \
--cc=dyoung@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).