Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

From: David Woodhouse <dwmw2@infradead.org>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
	catalin.marinas@arm.com, will.deacon@arm.com
Cc: mark.rutland@arm.com, panand@redhat.com,
	ard.biesheuvel@linaro.org, geoff@infradead.org,
	kexec@lists.infradead.org, james.morse@arm.com,
	Mark Salter <msalter@redhat.com>,
	bauerman@linux.vnet.ibm.com, sgoel@codeaurora.org,
	dyoung@redhat.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel
Date: Mon, 03 Apr 2017 09:18:12 +0100	[thread overview]
Message-ID: <1491207492.6020.8.camel@infradead.org> (raw)
In-Reply-To: <20170328065130.16019-2-takahiro.akashi@linaro.org>

[-- Attachment #1.1: Type: text/plain, Size: 1730 bytes --]

On Tue, 2017-03-28 at 15:51 +0900, AKASHI Takahiro wrote:
> 
> +       if (crash_base == 0) {
> +               /* Current arm64 boot protocol requires 2MB alignment */
> +               crash_base = memblock_find_in_range(0, ARCH_LOW_ADDRESS_LIMIT,
> +                               crash_size, SZ_2M);
> +               if (crash_base == 0) {
> +                       pr_warn("cannot allocate crashkernel (size:0x%llx)\n",
> +                               crash_size);
> +                       return;
> +               }
> +       } else {
> +               /* User specifies base address explicitly. */
> +               if (!memblock_is_region_memory(crash_base, crash_size)) {
> +                       pr_warn("cannot reserve crashkernel: region is not memory\n");
> +                       return;
> +               }
> +
> +               if (memblock_is_region_reserved(crash_base, crash_size)) {
> +                       pr_warn("cannot reserve crashkernel: region overlaps reserved memory\n");
> +                       return;
> +               }
> +
> +               if (!IS_ALIGNED(crash_base, SZ_2M)) {
> +                       pr_warn("cannot reserve crashkernel: base address is not 2MB aligned\n");
> +                       return;
> +               }

You still have typos here.

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec