From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNnzY-0004H4-Be for kexec@lists.infradead.org; Tue, 29 May 2018 23:25:26 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4TNOLwN175432 for ; Tue, 29 May 2018 19:25:13 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0b-001b2d01.pphosted.com with ESMTP id 2j9ewnb3nu-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 29 May 2018 19:25:13 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 May 2018 00:25:11 +0100 Subject: Re: [PATCH v4 8/8] module: replace the existing LSM hook in init_module From: Mimi Zohar Date: Tue, 29 May 2018 19:25:02 -0400 In-Reply-To: References: <1527616920-5415-1-git-send-email-zohar@linux.vnet.ibm.com> <1527616920-5415-9-git-send-email-zohar@linux.vnet.ibm.com> Mime-Version: 1.0 Message-Id: <1527636302.3534.46.camel@linux.vnet.ibm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Paul Moore , Kees Cook Cc: Ard Biesheuvel , Greg Kroah-Hartman , kexec@lists.infradead.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, David Howells , "Luis R . Rodriguez" , Eric Biederman , Jeff Vander Stoep , Casey Schaufler , linux-integrity@vger.kernel.org, Andres Rodriguez SGkgS2VlcywKCk1pc3NpbmcgZnJvbSB0aGlzIHBhdGNoIGFyZSB0aGUgbG9hZHBpbiBjaGFuZ2Vz LiDCoEJlZm9yZSBpbmNsdWRpbmcKdGhlbSBpbiB0aGUgbmV4dCB2ZXJzaW9uIG9mIHRoaXMgcGF0 Y2gsIGRvIHlvdSBwcmVmZXIgc2VwYXJhdGluZyB0aGUKaW5pdF9tb2R1bGUgZnJvbSB0aGUgZmlu aXRfbW9kdWxlIHN1cHBvcnQgaW4gbG9hZHBpbl9yZWFkX2ZpbGUoKSBvcgprZWVwaW5nIGl0IGFz IG9uZSBmdW5jdGlvbiwgbGlrZSBQYXVsIGZvciBTRUxpbnV4PwoKTWltaQoKT24gVHVlLCAyMDE4 LTA1LTI5IGF0IDE4OjM5IC0wNDAwLCBQYXVsIE1vb3JlIHdyb3RlOgo+IE9uIFR1ZSwgTWF5IDI5 LCAyMDE4IGF0IDI6MDIgUE0sIE1pbWkgWm9oYXIgPHpvaGFyQGxpbnV4LnZuZXQuaWJtLmNvbT4g d3JvdGU6Cj4gPiBCb3RoIHRoZSBpbml0X21vZHVsZSBhbmQgZmluaXRfbW9kdWxlIHN5c2NhbGxz IGNhbGwgZWl0aGVyIGRpcmVjdGx5Cj4gPiBvciBpbmRpcmVjdGx5IHRoZSBzZWN1cml0eV9rZXJu ZWxfcmVhZF9maWxlIExTTSBob29rLiAgVGhpcyBwYXRjaAo+ID4gcmVwbGFjZXMgdGhlIGRpcmVj dCBjYWxsIGluIGluaXRfbW9kdWxlIHdpdGggYSBjYWxsIHRvIHRoZSBuZXcKPiA+IHNlY3VyaXR5 X2tlcm5lbF9sb2FkX2RhdGEgaG9vayBhbmQgbWFrZXMgdGhlIGNvcnJlc3BvbmRpbmcgY2hhbmdl cyBpbgo+ID4gU0VMaW51eCBhbmQgSU1BLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IE1pbWkgWm9o YXIgPHpvaGFyQGxpbnV4LnZuZXQuaWJtLmNvbT4KPiA+IENjOiBKZWZmIFZhbmRlciBTdG9lcCA8 amVmZnZAZ29vZ2xlLmNvbT4KPiA+IENjOiBQYXVsIE1vb3JlIDxwYXVsQHBhdWwtbW9vcmUuY29t Pgo+ID4gQ2M6IENhc2V5IFNjaGF1ZmxlciA8Y2FzZXlAc2NoYXVmbGVyLWNhLmNvbT4KPiA+IC0t LQo+ID4gIGtlcm5lbC9tb2R1bGUuYyAgICAgICAgICAgICAgICAgICB8ICAyICstCj4gPiAgc2Vj dXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFfbWFpbi5jIHwgMjQgKysrKysrKysrKy0tLS0tLS0tLS0t LS0tCj4gPiAgc2VjdXJpdHkvc2VsaW51eC9ob29rcy5jICAgICAgICAgIHwgMjYgKysrKysrKysr KysrKysrKysrKystLS0tLS0KPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyks IDIxIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9rZXJuZWwvbW9kdWxlLmMgYi9r ZXJuZWwvbW9kdWxlLmMKPiA+IGluZGV4IGNlODA2NmI4ODE3OC4uYjk3YzY0MmI1YjRkIDEwMDY0 NAo+ID4gLS0tIGEva2VybmVsL21vZHVsZS5jCj4gPiArKysgYi9rZXJuZWwvbW9kdWxlLmMKPiA+ IEBAIC0yODc5LDcgKzI4NzksNyBAQCBzdGF0aWMgaW50IGNvcHlfbW9kdWxlX2Zyb21fdXNlcihj b25zdCB2b2lkIF9fdXNlciAqdW1vZCwgdW5zaWduZWQgbG9uZyBsZW4sCj4gPiAgICAgICAgIGlm IChpbmZvLT5sZW4gPCBzaXplb2YoKihpbmZvLT5oZHIpKSkKPiA+ICAgICAgICAgICAgICAgICBy ZXR1cm4gLUVOT0VYRUM7Cj4gPgo+ID4gLSAgICAgICBlcnIgPSBzZWN1cml0eV9rZXJuZWxfcmVh ZF9maWxlKE5VTEwsIFJFQURJTkdfTU9EVUxFKTsKPiA+ICsgICAgICAgZXJyID0gc2VjdXJpdHlf a2VybmVsX2xvYWRfZGF0YShMT0FESU5HX01PRFVMRSk7Cj4gPiAgICAgICAgIGlmIChlcnIpCj4g PiAgICAgICAgICAgICAgICAgcmV0dXJuIGVycjsKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvc2VjdXJp dHkvaW50ZWdyaXR5L2ltYS9pbWFfbWFpbi5jIGIvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFf bWFpbi5jCj4gPiBpbmRleCAzZGFlNjA1YTE2MDQuLjBmZjFkODE1MmY2ZSAxMDA2NDQKPiA+IC0t LSBhL3NlY3VyaXR5L2ludGVncml0eS9pbWEvaW1hX21haW4uYwo+ID4gKysrIGIvc2VjdXJpdHkv aW50ZWdyaXR5L2ltYS9pbWFfbWFpbi5jCj4gPiBAQCAtNDQxLDE3ICs0NDEsNiBAQCBzdGF0aWMg aW50IHJlYWRfaWRtYXBbUkVBRElOR19NQVhfSURdID0gewo+ID4gICAqLwo+ID4gIGludCBpbWFf cmVhZF9maWxlKHN0cnVjdCBmaWxlICpmaWxlLCBlbnVtIGtlcm5lbF9yZWFkX2ZpbGVfaWQgcmVh ZF9pZCkKPiA+ICB7Cj4gPiAtICAgICAgIGJvb2wgc2lnX2VuZm9yY2UgPSBpc19tb2R1bGVfc2ln X2VuZm9yY2VkKCk7Cj4gPiAtCj4gPiAtICAgICAgIGlmICghZmlsZSAmJiByZWFkX2lkID09IFJF QURJTkdfTU9EVUxFKSB7Cj4gPiAtICAgICAgICAgICAgICAgaWYgKCFzaWdfZW5mb3JjZSAmJiAo aW1hX2FwcHJhaXNlICYgSU1BX0FQUFJBSVNFX01PRFVMRVMpICYmCj4gPiAtICAgICAgICAgICAg ICAgICAgIChpbWFfYXBwcmFpc2UgJiBJTUFfQVBQUkFJU0VfRU5GT1JDRSkpIHsKPiA+IC0gICAg ICAgICAgICAgICAgICAgICAgIHByX2VycigiaW1wb3NzaWJsZSB0byBhcHByYWlzZSBhIG1vZHVs ZSB3aXRob3V0IGEgZmlsZSBkZXNjcmlwdG9yLiBzaWdfZW5mb3JjZSBrZXJuZWwgcGFyYW1ldGVy IG1pZ2h0IGhlbHBcbiIpOwo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIC1FQUND RVM7IC8qIElOVEVHUklUWV9VTktOT1dOICovCj4gPiAtICAgICAgICAgICAgICAgfQo+ID4gLSAg ICAgICAgICAgICAgIHJldHVybiAwOyAgICAgICAvKiBXZSByZWx5IG9uIG1vZHVsZSBzaWduYXR1 cmUgY2hlY2tpbmcgKi8KPiA+IC0gICAgICAgfQo+ID4gLQo+ID4gICAgICAgICBpZiAocmVhZF9p ZCA9PSBSRUFESU5HX0ZJUk1XQVJFX1BSRUFMTE9DX0JVRkZFUikgewo+ID4gICAgICAgICAgICAg ICAgIGlmICgoaW1hX2FwcHJhaXNlICYgSU1BX0FQUFJBSVNFX0ZJUk1XQVJFKSAmJgo+ID4gICAg ICAgICAgICAgICAgICAgICAoaW1hX2FwcHJhaXNlICYgSU1BX0FQUFJBSVNFX0VORk9SQ0UpKSB7 Cj4gPiBAQCAtNDkwLDkgKzQ3OSw2IEBAIGludCBpbWFfcG9zdF9yZWFkX2ZpbGUoc3RydWN0IGZp bGUgKmZpbGUsIHZvaWQgKmJ1ZiwgbG9mZl90IHNpemUsCj4gPiAgICAgICAgICAgICAgICAgcmV0 dXJuIDA7Cj4gPiAgICAgICAgIH0KPiA+Cj4gPiAtICAgICAgIGlmICghZmlsZSAmJiByZWFkX2lk ID09IFJFQURJTkdfTU9EVUxFKSAvKiBNT0RVTEVfU0lHX0ZPUkNFIGVuYWJsZWQgKi8KPiA+IC0g ICAgICAgICAgICAgICByZXR1cm4gMDsKPiA+IC0KPiA+ICAgICAgICAgLyogcGVybWl0IHNpZ25l ZCBjZXJ0cyAqLwo+ID4gICAgICAgICBpZiAoIWZpbGUgJiYgcmVhZF9pZCA9PSBSRUFESU5HX1g1 MDlfQ0VSVElGSUNBVEUpCj4gPiAgICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4gPiBAQCAtNTIx LDYgKzUwNyw4IEBAIGludCBpbWFfcG9zdF9yZWFkX2ZpbGUoc3RydWN0IGZpbGUgKmZpbGUsIHZv aWQgKmJ1ZiwgbG9mZl90IHNpemUsCj4gPiAgICovCj4gPiAgaW50IGltYV9sb2FkX2RhdGEoZW51 bSBrZXJuZWxfbG9hZF9kYXRhX2lkIGlkKQo+ID4gIHsKPiA+ICsgICAgICAgYm9vbCBzaWdfZW5m b3JjZTsKPiA+ICsKPiA+ICAgICAgICAgaWYgKChpbWFfYXBwcmFpc2UgJiBJTUFfQVBQUkFJU0Vf RU5GT1JDRSkgIT0gSU1BX0FQUFJBSVNFX0VORk9SQ0UpCj4gPiAgICAgICAgICAgICAgICAgcmV0 dXJuIDA7Cj4gPgo+ID4gQEAgLTUzNiw2ICs1MjQsMTQgQEAgaW50IGltYV9sb2FkX2RhdGEoZW51 bSBrZXJuZWxfbG9hZF9kYXRhX2lkIGlkKQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgcHJf ZXJyKCJQcmV2ZW50IGZpcm13YXJlIHN5c2ZzIGZhbGxiYWNrIGxvYWRpbmcuXG4iKTsKPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRUFDQ0VTOyAvKiBJTlRFR1JJVFlfVU5LTk9X TiAqLwo+ID4gICAgICAgICAgICAgICAgIH0KPiA+ICsgICAgICAgICAgICAgICBicmVhazsKPiA+ ICsgICAgICAgY2FzZSBMT0FESU5HX01PRFVMRToKPiA+ICsgICAgICAgICAgICAgICBzaWdfZW5m b3JjZSA9IGlzX21vZHVsZV9zaWdfZW5mb3JjZWQoKTsKPiA+ICsKPiA+ICsgICAgICAgICAgICAg ICBpZiAoIXNpZ19lbmZvcmNlICYmIChpbWFfYXBwcmFpc2UgJiBJTUFfQVBQUkFJU0VfTU9EVUxF UykpIHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHByX2VycigiaW1wb3NzaWJsZSB0byBh cHByYWlzZSBhIG1vZHVsZSB3aXRob3V0IGEgZmlsZSBkZXNjcmlwdG9yLiBzaWdfZW5mb3JjZSBr ZXJuZWwgcGFyYW1ldGVyIG1pZ2h0IGhlbHBcbiIpOwo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIC1FQUNDRVM7IC8qIElOVEVHUklUWV9VTktOT1dOICovCj4gPiArICAgICAgICAg ICAgICAgfQo+ID4gICAgICAgICBkZWZhdWx0Ogo+ID4gICAgICAgICAgICAgICAgIGJyZWFrOwo+ ID4gICAgICAgICB9Cj4gPiBkaWZmIC0tZ2l0IGEvc2VjdXJpdHkvc2VsaW51eC9ob29rcy5jIGIv c2VjdXJpdHkvc2VsaW51eC9ob29rcy5jCj4gPiBpbmRleCAwMmViZDE1ODVlYWYuLmUwMjE4NjQ3 MGZjNSAxMDA2NDQKPiA+IC0tLSBhL3NlY3VyaXR5L3NlbGludXgvaG9va3MuYwo+ID4gKysrIGIv c2VjdXJpdHkvc2VsaW51eC9ob29rcy5jCj4gPiBAQCAtNDAxOCwxMiArNDAxOCw2IEBAIHN0YXRp YyBpbnQgc2VsaW51eF9rZXJuZWxfbW9kdWxlX2Zyb21fZmlsZShzdHJ1Y3QgZmlsZSAqZmlsZSkK PiA+ICAgICAgICAgdTMyIHNpZCA9IGN1cnJlbnRfc2lkKCk7Cj4gPiAgICAgICAgIGludCByYzsK PiA+Cj4gPiAtICAgICAgIC8qIGluaXRfbW9kdWxlICovCj4gPiAtICAgICAgIGlmIChmaWxlID09 IE5VTEwpCj4gPiAtICAgICAgICAgICAgICAgcmV0dXJuIGF2Y19oYXNfcGVybSgmc2VsaW51eF9z dGF0ZSwKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNpZCwgc2lkLCBT RUNDTEFTU19TWVNURU0sCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgU1lTVEVNX19NT0RVTEVfTE9BRCwgTlVMTCk7Cj4gPiAtCj4gPiAgICAgICAgIC8qIGZpbml0 X21vZHVsZSAqLwo+ID4KPiA+ICAgICAgICAgYWQudHlwZSA9IExTTV9BVURJVF9EQVRBX0ZJTEU7 Cj4gPiBAQCAtNDA0Myw2ICs0MDM3LDI1IEBAIHN0YXRpYyBpbnQgc2VsaW51eF9rZXJuZWxfbW9k dWxlX2Zyb21fZmlsZShzdHJ1Y3QgZmlsZSAqZmlsZSkKPiA+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgU1lTVEVNX19NT0RVTEVfTE9BRCwgJmFkKTsKPiA+ICB9Cj4gPgo+ID4gK3N0 YXRpYyBpbnQgc2VsaW51eF9rZXJuZWxfbG9hZF9kYXRhKGVudW0ga2VybmVsX2xvYWRfZGF0YV9p ZCBpZCkKPiA+ICt7Cj4gPiArICAgICAgIHUzMiBzaWQ7Cj4gPiArICAgICAgIGludCByYyA9IDA7 Cj4gPiArCj4gPiArICAgICAgIHN3aXRjaCAoaWQpIHsKPiA+ICsgICAgICAgY2FzZSBMT0FESU5H X01PRFVMRToKPiA+ICsgICAgICAgICAgICAgICBzaWQgPSBjdXJyZW50X3NpZCgpOwo+ID4gKwo+ ID4gKyAgICAgICAgICAgICAgIC8qIGluaXRfbW9kdWxlICovCj4gPiArICAgICAgICAgICAgICAg cmV0dXJuIGF2Y19oYXNfcGVybSgmc2VsaW51eF9zdGF0ZSwgc2lkLCBzaWQsIFNFQ0NMQVNTX1NZ U1RFTSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNZU1RFTV9fTU9E VUxFX0xPQUQsIE5VTEwpOwo+ID4gKyAgICAgICBkZWZhdWx0Ogo+ID4gKyAgICAgICAgICAgICAg IGJyZWFrOwo+ID4gKyAgICAgICB9Cj4gPiArCj4gPiArICAgICAgIHJldHVybiByYzsKPiA+ICt9 Cj4gCj4gSSdtIG5vdCBhIGZhbiBvZiB0aGUgZHVwbGljYXRpb24gaGVyZS4gIElmIHdlIG11c3Qg aGF2ZSBhIG5ldyBMU00gaG9vawo+IGZvciB0aGlzLCBjYW4gd2UgYXQgbGVhc3QgaGF2ZSBpdCBj YWxsCj4gc2VsaW51eF9rZXJuZWxfbW9kdWxlX2Zyb21fZmlsZSgpIHNvIHdlIGhhdmUgYWxsIHRo ZSBrZXJuZWwgbW9kdWxlCj4gbG9hZGluZyBsb2dpYy9jb250cm9scyBpbiBvbmUgZnVuY3Rpb24/ ICBZZXMsIEkgdW5kZXJzdGFuZCB0aGVyZSBhcmUKPiBkaWZmZXJlbmNlcyBiZXR3ZWVuIGluaXRf bW9kdWxlKCkgYW5kIGZpbml0X21vZHVsZSgpIGJ1dCBJIGxpa2UKPiBoYW5kbGluZyB0aGVtIGJv dGggaW4gb25lIGZ1bmN0aW9uIGFzIHdlIGRvIHRvZGF5Lgo+IAo+ID4gIHN0YXRpYyBpbnQgc2Vs aW51eF9rZXJuZWxfcmVhZF9maWxlKHN0cnVjdCBmaWxlICpmaWxlLAo+ID4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZW51bSBrZXJuZWxfcmVhZF9maWxlX2lkIGlkKQo+ID4g IHsKPiA+IEBAIC02OTUwLDYgKzY5NjMsNyBAQCBzdGF0aWMgc3RydWN0IHNlY3VyaXR5X2hvb2tf bGlzdCBzZWxpbnV4X2hvb2tzW10gX19sc21fcm9fYWZ0ZXJfaW5pdCA9IHsKPiA+ICAgICAgICAg TFNNX0hPT0tfSU5JVChrZXJuZWxfYWN0X2FzLCBzZWxpbnV4X2tlcm5lbF9hY3RfYXMpLAo+ID4g ICAgICAgICBMU01fSE9PS19JTklUKGtlcm5lbF9jcmVhdGVfZmlsZXNfYXMsIHNlbGludXhfa2Vy bmVsX2NyZWF0ZV9maWxlc19hcyksCj4gPiAgICAgICAgIExTTV9IT09LX0lOSVQoa2VybmVsX21v ZHVsZV9yZXF1ZXN0LCBzZWxpbnV4X2tlcm5lbF9tb2R1bGVfcmVxdWVzdCksCj4gPiArICAgICAg IExTTV9IT09LX0lOSVQoa2VybmVsX2xvYWRfZGF0YSwgc2VsaW51eF9rZXJuZWxfbG9hZF9kYXRh KSwKPiA+ICAgICAgICAgTFNNX0hPT0tfSU5JVChrZXJuZWxfcmVhZF9maWxlLCBzZWxpbnV4X2tl cm5lbF9yZWFkX2ZpbGUpLAo+ID4gICAgICAgICBMU01fSE9PS19JTklUKHRhc2tfc2V0cGdpZCwg c2VsaW51eF90YXNrX3NldHBnaWQpLAo+ID4gICAgICAgICBMU01fSE9PS19JTklUKHRhc2tfZ2V0 cGdpZCwgc2VsaW51eF90YXNrX2dldHBnaWQpLAo+ID4gLS0KPiA+IDIuNy41Cj4gPgo+IAoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxp bmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK