Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Kairui Song <kasong@redhat.com>, linux-kernel@vger.kernel.org
Cc: jwboyer@fedoraproject.org, ebiggers@google.com,
	dyoung@redhat.com, nayna@linux.ibm.com,
	kexec@lists.infradead.org, jmorris@namei.org,
	dhowells@redhat.com, keyrings@vger.kernel.org,
	linux-integrity@vger.kernel.org, dwmw2@infradead.org,
	bauerman@linux.ibm.com, serge@hallyn.com
Subject: Re: [RFC PATCH v2 1/2] integrity, KEYS: add a reference to platform keyring
Date: Tue, 15 Jan 2019 10:34:15 -0500	[thread overview]
Message-ID: <1547566455.4156.283.camel@linux.ibm.com> (raw)
In-Reply-To: <20190115094542.17129-2-kasong@redhat.com>

On Tue, 2019-01-15 at 17:45 +0800, Kairui Song wrote:
[snip]

> diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> index f45d6edecf99..bfabc2a8111d 100644
> --- a/security/integrity/digsig.c
> +++ b/security/integrity/digsig.c
> @@ -89,6 +89,12 @@ static int __integrity_init_keyring(const unsigned int id, key_perm_t perm,
>  		keyring[id] = NULL;
>  	}
>  
> +#ifdef CONFIG_INTEGRITY_PLATFORM_KEYRING
> +	if (id == INTEGRITY_KEYRING_PLATFORM) {
> +		set_platform_trusted_keys(keyring[id]);
> +	}
> +#endif
> +
>  	return err;
>  }
>  

Any reason for setting it here as opposed to in the caller
platform_keyring_init()?

Mimi


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2019-01-15 15:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15  9:45 [RFC PATCH v2 0/2] let kexec_file_load use platform keyring to verify the kernel image Kairui Song
2019-01-15  9:45 ` [RFC PATCH v2 1/2] integrity, KEYS: add a reference to platform keyring Kairui Song
2019-01-15 15:34   ` Mimi Zohar [this message]
2019-01-15 15:47     ` Kairui Song
2019-01-15 15:54       ` Mimi Zohar
2019-01-15  9:45 ` [RFC PATCH v2 2/2] kexec, KEYS: Make use of platform keyring for signature verify Kairui Song
2019-01-15 15:46   ` Mimi Zohar
2019-01-15 16:48     ` Kairui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1547566455.4156.283.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=bauerman@linux.ibm.com \
    --cc=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=dyoung@redhat.com \
    --cc=ebiggers@google.com \
    --cc=jmorris@namei.org \
    --cc=jwboyer@fedoraproject.org \
    --cc=kasong@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nayna@linux.ibm.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox