From: Junichi Nomura <j-nomura@ce.jp.nec.com>
To: Borislav Petkov <bp@alien8.de>, Kairui Song <kasong@redhat.com>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Baoquan He <bhe@redhat.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
Chao Fan <fanc.fnst@cn.fujitsu.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Young <dyoung@redhat.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] x86/kexec: Add ACPI NVS region to the ident map
Date: Mon, 10 Jun 2019 11:07:05 +0000 [thread overview]
Message-ID: <1555938c-e00f-d40f-5f24-146aec7a67eb@ce.jp.nec.com> (raw)
In-Reply-To: <20190610105959.GB5488@zn.tnic>
Hi Kairui, Boris,
On 6/10/19 7:59 PM, Borislav Petkov wrote:
> On Mon, Jun 10, 2019 at 06:18:50PM +0800, Kairui Song wrote:
>> Hi Boris, unfortunately I don't have a real machine which only have
>> the NVS region. I did fake the memmap to emulate such problem but
>> can't really promise this will fix the real case. So just declare it
>> won't break anything that is already working. And I'm asking Junichi
>> to have a try as he reported this issue on the machines he has.
>
> Yes, this is how you should do it. First you test on a real hardware -
> if the issue is such that needs a real hardware to verify - and if it
> passes, *then* you send the patch.
>
> If you don't have access to the box, then ask someone who has.
>
> But for the future, please do not send untested patches in a hurry,
> hoping that they would work. This could cause more trouble than the
> little time you might save speculating it'll all go fine.
I tested the patch on such a machine on top of the current tip/master
f9818950848 ("Marge branch 'linus'") and it works fine.
Without the patch, kexec -l fails.
I had tested the version I posted here on bunch of physical machines
I had access and confirmed it didn't broke working setups:
https://lore.kernel.org/lkml/20190515051717.GA13703@jeru.linux.bs1.fc.nec.co.jp/
Since the logic in the patch seems unchanged, I'm very sure it's ok.
--
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-06-10 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 7:36 [PATCH] x86/kexec: Add ACPI NVS region to the ident map Kairui Song
2019-06-10 9:51 ` Borislav Petkov
2019-06-10 10:18 ` Kairui Song
2019-06-10 10:59 ` Borislav Petkov
2019-06-10 11:07 ` Junichi Nomura [this message]
2019-06-10 11:24 ` Borislav Petkov
2019-06-10 9:53 ` Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555938c-e00f-d40f-5f24-146aec7a67eb@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dirk.vandermerwe@netronome.com \
--cc=dyoung@redhat.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=kasong@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox