From: Bhupesh Sharma <bhsharma@redhat.com>
To: kexec@lists.infradead.org
Cc: bhupesh.linux@gmail.com, bhsharma@redhat.com, horms@verge.net.au,
takahiro.akashi@linaro.org
Subject: [PATCH 1/4] kexec/kexec.c: Add the missing close() for fd used for kexec_file_load()
Date: Thu, 11 Jul 2019 01:24:26 +0530 [thread overview]
Message-ID: <1562788469-22935-2-git-send-email-bhsharma@redhat.com> (raw)
In-Reply-To: <1562788469-22935-1-git-send-email-bhsharma@redhat.com>
In kexec/kexec.c, we open() the kernel Image file and pass this file
descriptor to the kexec_file_load() system call, but never call a
corresponding close().
Fix the same via this patch.
Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
---
kexec/kexec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kexec/kexec.c b/kexec/kexec.c
index 32ae56c8f1c3..8ca3b457cac8 100644
--- a/kexec/kexec.c
+++ b/kexec/kexec.c
@@ -1234,6 +1234,8 @@ static int do_kexec_file_load(int fileind, int argc, char **argv,
if (ret != 0)
fprintf(stderr, "kexec_file_load failed: %s\n",
strerror(errno));
+
+ close(kernel_fd);
return ret;
}
--
2.7.4
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-07-10 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 19:54 [PATCH 0/4] kexec/arm64: Add support for zlib compressed kernel images (Image.gz) Bhupesh Sharma
2019-07-10 19:54 ` Bhupesh Sharma [this message]
2019-07-10 19:54 ` [PATCH 2/4] kexec-uImage-arm64.c: Fix return value of uImage_arm64_probe() Bhupesh Sharma
2019-07-10 19:54 ` [PATCH 3/4] kexec/kexec-zlib.h: Add 'is_zlib_file()' helper function Bhupesh Sharma
2019-07-11 9:58 ` Simon Horman
2019-07-12 8:06 ` Bhupesh Sharma
2019-07-10 19:54 ` [PATCH 4/4] kexec/arm64: Add support for handling zlib compressed (Image.gz) image Bhupesh Sharma
2019-07-11 10:08 ` Simon Horman
2019-07-12 8:06 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562788469-22935-2-git-send-email-bhsharma@redhat.com \
--to=bhsharma@redhat.com \
--cc=bhupesh.linux@gmail.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=takahiro.akashi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox