From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from v094114.home.net.pl ([79.96.170.134]) by merlin.infradead.org with smtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1W1Qrz-0005cB-41 for kexec@lists.infradead.org; Fri, 10 Jan 2014 01:26:43 +0000 From: "Rafael J. Wysocki" Subject: Re: kdump failed because of hotplug memory adding in kdump kernel Date: Fri, 10 Jan 2014 02:40:14 +0100 Message-ID: <1573868.THSJocqDKH@vostro.rjw.lan> In-Reply-To: <1389292470.1792.109.camel@misato.fc.hp.com> References: <52CD6E33.400@redhat.com> <20140109182310.GG25897@redhat.com> <1389292470.1792.109.camel@misato.fc.hp.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Toshi Kani Cc: Baoquan , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, tangchen@cn.fujitsu.com, linux-acpi@vger.kernel.org, zhangyanfei@cn.fujitsu.com, dyoung@redhat.com, Vivek Goyal On Thursday, January 09, 2014 11:34:30 AM Toshi Kani wrote: > On Thu, 2014-01-09 at 13:23 -0500, Vivek Goyal wrote: > > On Thu, Jan 09, 2014 at 10:24:25AM -0700, Toshi Kani wrote: > > > > [..] > > > > I think creating a new command line option is simpler as compared to > > > > creating a new flag in bootparam which in turn disables memory hotplug. > > > > More users can use that option. For example, if for some reason hotplug > > > > code is crashing, one can just disable it on command line as work around > > > > and move on. > > > > > > I do not have a strong opinion about having such option. However, I > > > think it is more user friendly to keep the exactmap option works alone > > > on any platforms. > > > > I think we should create internally a variable which will disable memory > > hotplug. And set that variable based on memmap=exactmap, mem=X and also > > provide a way to disable memory hotplug directly using command line > > option. > > > > Current kexec-tools can use memmap=exactmap and be happy. I am writing > > a new kexec syscall and will not be using memmap=exactmap and would need > > to use that command line option to disable memory hotplug behavior. > > Sounds good to me. Agreed. Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec