From: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: linux-ima-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org, kexec@lists.infradead.org,
kbuild-all@01.org
Subject: Re: [integrity:next-restore-kexec 18/31] include/linux/kexec.h:400:52: warning: 'struct kexec_buf' declared inside parameter list will not be visible outside of this definition or declaration
Date: Tue, 23 Aug 2016 12:34:59 -0300 [thread overview]
Message-ID: <1617934.na55SdnaSp@hactar> (raw)
In-Reply-To: <201608232256.6ONII0WZ%fengguang.wu@intel.com>
Am Dienstag, 23 August 2016, 22:17:59 schrieb kbuild test robot:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git
> next-restore-kexec head: 62bc4b565254de4796a0835f6f67569eb4835f9f
> commit: f9f57350e53441210120931fc4e0163cf833e648 [18/31] kexec_file: Add
> buffer hand-over support for the next kernel config: i386-defconfig
> (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
> git checkout f9f57350e53441210120931fc4e0163cf833e648
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All warnings (new ones prefixed by >>):
>
> In file included from drivers/pci/pci-driver.c:22:0:
> >> include/linux/kexec.h:400:52: warning: 'struct kexec_buf' declared
> >> inside parameter list will not be visible outside of this definition
> >> or declaration
> static inline int kexec_add_handover_buffer(struct kexec_buf *kbuf)
This happens when CONFIG_KEXEC=y but CONFIG_KEXEC_FILE=n, and is fixed by
the following change, which will be in my next revision of the kexec
buffer hand-over series:
Fix for "kexec_file: Add buffer hand-over support for the next kernel"
Declare stub struct kexec_buf when CONFIG_KEXEC_FILE=n.
diff --git a/include/linux/kexec.h b/include/linux/kexec.h
index 6ec09e85efd9..29f98f816e92 100644
--- a/include/linux/kexec.h
+++ b/include/linux/kexec.h
@@ -404,6 +404,8 @@ int kexec_add_handover_buffer(struct kexec_buf *kbuf);
int __weak kexec_get_handover_buffer(void **addr, unsigned long *size);
int __weak kexec_free_handover_buffer(void);
#else
+struct kexec_buf;
+
static inline bool kexec_can_hand_over_buffer(void)
{
return false;
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
parent reply other threads:[~2016-08-23 15:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <201608232256.6ONII0WZ%fengguang.wu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617934.na55SdnaSp@hactar \
--to=bauerman@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=kexec@lists.infradead.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox