Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "YAMAZAKI MASAMITSU(山崎 真光)" <yamazaki-msmt@nec.com>
To: "Tao Liu" <ltao@redhat.com>,
	"HAGIO KAZUHITO(萩尾 一仁)" <k-hagio-ab@nec.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Cc: "aravinda@linux.vnet.ibm.com" <aravinda@linux.vnet.ibm.com>,
	"devel@lists.crash-utility.osci.io"
	<devel@lists.crash-utility.osci.io>
Subject: Re: [PATCH RFC][makedumpfile 01/10] dwarf_info: Support kernel address randomization
Date: Mon, 8 Sep 2025 11:11:19 +0000	[thread overview]
Message-ID: <16a049cc-11c1-4e46-84a3-5ff5f0f00c00@nec.com> (raw)
In-Reply-To: <20250610095743.18073-2-ltao@redhat.com>

Hi,Liu

Thanks your patch. What kind of environment did you test
this KASLR problem ? Especialy is it kernel verssion
6.11.8-300.fc41.x86_64 ? Have you checked other versions?
Additionally, do you know the version of eppic ?

Also, if possible, show this problem results when an error occurs
and the results when it is correct. Please tell me.

Sincerely

On 2025/06/10 18:57, Tao Liu wrote:
> There is a bug of not supporting randomized kernel address, this patch fix it.
>
> Signed-off-by: Tao Liu <ltao@redhat.com>
> ---
>   erase_info.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/erase_info.c b/erase_info.c
> index af6bfae..b67d1d0 100644
> --- a/erase_info.c
> +++ b/erase_info.c
> @@ -1881,7 +1881,7 @@ get_symbol_addr_all(char *name) {
>   	if (!strcmp(get_dwarf_module_name(), "vmlinux")) {
>   		symbol_addr = get_symbol_addr(name);
>   		if (symbol_addr)
> -			return symbol_addr;
> +			return symbol_addr + info->kaslr_offset;
>   
>   		vmlinux_searched = 1;
>   	}
> @@ -1942,9 +1942,9 @@ get_symbol_addr_all(char *name) {
>   	 * this function is called with debuginfo set to a particular
>   	 * kernel module and we are looking for symbol in vmlinux
>   	 */
> -	if (!vmlinux_searched)
> -		return get_symbol_addr(name);
> -	else
> +	if (!vmlinux_searched && !!(symbol_addr = get_symbol_addr(name))) {
> +		return symbol_addr + info->kaslr_offset;
> +	} else
>   		return NOT_FOUND_SYMBOL;
>   }
>   

  reply	other threads:[~2025-09-08 12:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10  9:57 [PATCH RFC][makedumpfile 00/10] btf/kallsyms based eppic extension for mm page filtering Tao Liu
2025-06-10  9:57 ` [PATCH RFC][makedumpfile 01/10] dwarf_info: Support kernel address randomization Tao Liu
2025-09-08 11:11   ` YAMAZAKI MASAMITSU(山崎 真光) [this message]
2025-09-09  5:24     ` Tao Liu
2025-09-29  6:30   ` HAGIO KAZUHITO(萩尾 一仁)
2025-09-30  0:34     ` Tao Liu
2025-09-30  1:28       ` HAGIO KAZUHITO(萩尾 一仁)
2025-09-30  1:44         ` Tao Liu
2025-06-10  9:57 ` [PATCH RFC][makedumpfile 02/10] dwarf_info: Fix a infinite recursion bug for search_domain Tao Liu
2025-10-03  7:22   ` YAMAZAKI MASAMITSU(山崎 真光)
2025-10-05 23:25     ` Tao Liu
2025-10-17  4:21   ` HAGIO KAZUHITO(萩尾 一仁)
2025-10-20  3:52     ` Tao Liu
2025-06-10  9:57 ` [PATCH RFC][makedumpfile 03/10] Add page filtering function Tao Liu
2025-06-10  9:57 ` [PATCH RFC][makedumpfile 04/10] Add btf/kallsyms support for symbol type/address resolving Tao Liu
2025-06-10  9:57 ` [PATCH RFC][makedumpfile 05/10] Export necessary btf/kallsyms functions to eppic extension Tao Liu
2025-06-10  9:57 ` [PATCH RFC][makedumpfile 06/10] Port the maple tree data structures and functions Tao Liu
2025-06-10  9:57 ` [PATCH RFC][makedumpfile 07/10] Supporting main() as the entry of eppic script Tao Liu
2025-06-10  9:57 ` [PATCH RFC][makedumpfile 08/10] Enable page filtering for dwarf eppic Tao Liu
2025-06-10  9:57 ` [PATCH RFC][makedumpfile 09/10] Enable page filtering for btf/kallsyms eppic Tao Liu
2025-06-10  9:57 ` [PATCH RFC][makedumpfile 10/10] Introducing 2 eppic scripts to test the dwarf/btf eppic extension Tao Liu
2025-08-05  3:16 ` [PATCH RFC][makedumpfile 00/10] btf/kallsyms based eppic extension for mm page filtering Tao Liu
2025-08-07 11:42   ` YAMAZAKI MASAMITSU(山崎 真光)
2025-08-11  0:04     ` Tao Liu
2025-09-05 12:41       ` YAMAZAKI MASAMITSU(山崎 真光)
2025-09-09  1:56         ` Tao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16a049cc-11c1-4e46-84a3-5ff5f0f00c00@nec.com \
    --to=yamazaki-msmt@nec.com \
    --cc=aravinda@linux.vnet.ibm.com \
    --cc=devel@lists.crash-utility.osci.io \
    --cc=k-hagio-ab@nec.com \
    --cc=kexec@lists.infradead.org \
    --cc=ltao@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox