From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx4-phx2.redhat.com ([209.132.183.25]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T108M-0007mE-Gc for kexec@lists.infradead.org; Mon, 13 Aug 2012 19:17:03 +0000 Date: Mon, 13 Aug 2012 15:16:53 -0400 (EDT) From: Dave Anderson Message-ID: <1827880283.12350529.1344885413402.JavaMail.root@redhat.com> In-Reply-To: <20120813073754.GA2482@host-192-168-1-59.local.net-space.pl> Subject: Re: [PATCH v2 0/6] crash: Bundle of fixes for Xen MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Daniel Kiper Cc: olaf@aepfle.de, xen-devel@lists.xensource.com, konrad wilk , andrew cooper3 , ptesarik@suse.cz, jbeulich@suse.com, kexec@lists.infradead.org, crash-utility@redhat.com ----- Original Message ----- > On Fri, Aug 10, 2012 at 03:11:57PM -0400, Dave Anderson wrote: > > > > > > ----- Original Message ----- > > > Hi, > > > > > > It looks that Xen support for crash have not been maintained > > > since 2009. I am trying to fix this. Here it is bundle of fixes: > > > - xen: Always calculate max_cpus value, > > > - xen: Read only crash notes for onlined CPUs, > > > - x86/xen: Read variables from dynamically allocated per_cpu > > > data, > > > - xen: Get idle data from alternative source, > > > - xen: Read data correctly from dynamically allocated console > > > ring, too > > > (fixed in this release), > > > - xen: Add support for 3 level P2M tree (new patch in this > > > release). > > > > > > Daniel > > > > Hi Daniel, > > > > The original 5 updates specific to the Xen hypervisor look OK, > > but new patch 6/6 is going to take some studying/testing to > > alleviate my backwards-compatibility worries. Can I ask whether > > you fully tested it with older 2-level P2M tree kernels? > > As you asked me earlier I have tested all patches on Xen 3.1 and 4.1, > Linux Kernel Ver. 2.6.18 (P2M array), 2.6.36 (2 level P2M tree) > and 2.6.39 (3 level P2M tree). Additionaly, there were some internal > tests done by others in my company. > > Daniel OK good. It tests OK on a few older pvops kernels that I have on hand. The only thing I've changed is to handle compiler warnings in x86_64.c and x86.c by initializing p2m_top to NULL in x86_64_pvops_xendump_p2m_l3_create() and x86_pvops_xendump_p2m_l3_create(). I also used GETBUF() in those two functions to avoid having to add the malloc-failure line. Queued for crash-6.0.9. Thanks, Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec