[PATCH] kexec: include asm/early_ioremap.h

[PATCH] kexec: include asm/early_ioremap.h

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The early_memremap() function is decleared in a header that is only indirectly
included here:

kernel/kexec_handover.c:1116:8: error: call to undeclared function 'early_memremap'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
 1116 |         fdt = early_memremap(fdt_phys, fdt_len);
      |               ^

Fixes: 4bfe738ce89a ("kexec: add KHO support to kexec file loads")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/kexec_handover.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c
index 4bbc6f5ef723..3e8a0118e182 100644
--- a/kernel/kexec_handover.c
+++ b/kernel/kexec_handover.c
@@ -18,6 +18,9 @@
 #include <linux/memblock.h>
 #include <linux/notifier.h>
 #include <linux/page-isolation.h>
+
+#include <asm/early_ioremap.h>
+
 /*
  * KHO is tightly coupled with mm init and needs access to some of mm
  * internal APIs.
-- 
2.39.5

Re: [PATCH] kexec: include asm/early_ioremap.h

[Simon Horman]

On Wed, Apr 23, 2025 at 06:29:18PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The early_memremap() function is decleared in a header that is only indirectly
> included here:
> 
> kernel/kexec_handover.c:1116:8: error: call to undeclared function 'early_memremap'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>  1116 |         fdt = early_memremap(fdt_phys, fdt_len);
>       |               ^
> 
> Fixes: 4bfe738ce89a ("kexec: add KHO support to kexec file loads")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Hi Arnd,

I didn't try to reproduce this problem. And perhaps this isn't particularly
important. But, naively, I would have expected the following as it is
the commit the introduces calls to early_memremap() in exec_handover.c.

Fixes: b0a311dba688 ("kexec: add KHO parsing support")

Re: [PATCH] kexec: include asm/early_ioremap.h

[Arnd Bergmann]

On Thu, Apr 24, 2025, at 11:23, Simon Horman wrote:
> On Wed, Apr 23, 2025 at 06:29:18PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> The early_memremap() function is decleared in a header that is only indirectly
>> included here:
>> 
>> kernel/kexec_handover.c:1116:8: error: call to undeclared function 'early_memremap'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>>  1116 |         fdt = early_memremap(fdt_phys, fdt_len);
>>       |               ^
>> 
>> Fixes: 4bfe738ce89a ("kexec: add KHO support to kexec file loads")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I didn't try to reproduce this problem. And perhaps this isn't particularly
> important. But, naively, I would have expected the following as it is
> the commit the introduces calls to early_memremap() in exec_handover.c.
>
> Fixes: b0a311dba688 ("kexec: add KHO parsing support")

Yes, you are correct. I've sent a v2 now. Ideally Andrew can just fold
the fixup into the "kexec: add KHO parsing support" patch, in which
case my incorrect changelog text disappears.

    Arnd