From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1JMsJT-0007eR-5Z for kexec@lists.infradead.org; Wed, 06 Feb 2008 22:00:22 +0000 Date: Wed, 6 Feb 2008 23:00:01 +0100 From: Ingo Molnar Subject: Re: [PATCH], issue EOI to APIC prior to calling crash_kexec in die_nmi path Message-ID: <20080206220001.GA15155@elte.hu> References: <20080206192555.GA24910@hmsendeavour.rdu.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20080206192555.GA24910@hmsendeavour.rdu.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org+dwmw2=infradead.org@lists.infradead.org To: Neil Horman Cc: tglx@linutronix.de, mingo@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, hpa@zytor.com * Neil Horman wrote: > if (!user_mode_vm(regs)) { > + nmi_exit(); > + local_irq_enable(); > current->thread.trap_no = 2; > crash_kexec(regs); looks good to me, but please move the local_irq_enable() to within crash_kexec() instead - probably inside the "got the kexec lock" section. That makes crash_kexec() use generally safer too i guess: right it seems that die() too can call crash_kexec() with irqs disabled - and can thus hang in smp_send_stop() [or wherever it hung before]. Ingo _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec