From: Bernhard Walle <bwalle@suse.de>
To: kexec@lists.infradead.org
Subject: Re: [PATCH] Fix compilation warning
Date: Tue, 26 Feb 2008 08:58:35 +0100 [thread overview]
Message-ID: <20080226075834.GA3662@suse.de> (raw)
In-Reply-To: <20080222090239.GA25249@verge.net.au>
* Simon Horman <horms@verge.net.au> [2008-02-22 10:02]:
> On Thu, Feb 21, 2008 at 10:28:33AM +0100, Bernhard Walle wrote:
> > * Simon Horman <horms@verge.net.au> [2008-02-21 10:21]:
> > > On Wed, Feb 20, 2008 at 09:07:55AM +0100, Bernhard Walle wrote:
> > > > This patch fixes following compilation warning:
> > > >
> > > > purgatory/purgatory.c:21: warning: passing argument 2 of 'sha256_update' makes pointer from integer without a cast
> > > >
> > >
> > > Thanks Bernhard, I have queued that up.
> > > Although I notice that on arm the warning turns into
> > >
> > > purgatory/purgatory.c: In function 'verify_sha256_digest':
> > > purgatory/purgatory.c:21: warning: cast to pointer from integer of different size
> >
> > Isn't this the case on every 32 bit system?
>
> Yes, now you mention it, I expect so. I guess its not a problem.
But you didn't merge the patch. ;) Here's a version that should not
give any warnings ...
----------------------------
This patch fixes following compilation warning:
purgatory/purgatory.c:21: warning: passing argument 2 of 'sha256_update' makes pointer from integer without a cast
Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
purgatory/purgatory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/purgatory/purgatory.c
+++ b/purgatory/purgatory.c
@@ -18,7 +18,7 @@ void verify_sha256_digest(void)
sha256_starts(&ctx);
end = &sha256_regions[sizeof(sha256_regions)/sizeof(sha256_regions[0])];
for(ptr = sha256_regions; ptr < end; ptr++) {
- sha256_update(&ctx, ptr->start, ptr->len);
+ sha256_update(&ctx, (uint8_t *)((uintptr_t)ptr->start), ptr->len);
}
sha256_finish(&ctx, digest);
if (memcmp(digest, sha256_digest, sizeof(digest)) != 0) {
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2008-02-26 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 8:07 [PATCH] Fix compilation warning Bernhard Walle
2008-02-21 9:21 ` Simon Horman
2008-02-21 9:28 ` Bernhard Walle
2008-02-22 9:02 ` Simon Horman
2008-02-26 7:58 ` Bernhard Walle [this message]
2008-02-27 3:44 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226075834.GA3662@suse.de \
--to=bwalle@suse.de \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox