From: Bernhard Walle <bwalle@suse.de>
To: Jamey Sharp <jamey@thetovacompany.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] Fix implicit declaration of inb/outb
Date: Tue, 3 Jun 2008 09:36:18 +0200 [thread overview]
Message-ID: <20080603093618.7974ffec@halley.suse.de> (raw)
In-Reply-To: <e2ed954f0806021843r648e4276v6c0d49aa1f601e17@mail.gmail.com>
* Jamey Sharp [2008-06-02 18:43]:
>
> Oh, dear--that doesn't work.
Thanks for catching that issue. But it also means that it *didn't* work
on x86-64 because inb() needed to call a function (I don't think that
the compiler did inline something when it even didn't know the
prototype).
My next patch should address that issue by just using the same header
file for i386 and x86-64. No need for code duplication here. And I
think we should use __always_inline__ in that case (yes, it's GNU only
but I think we can afford that for kexec-tools) to make sure that the
inlining takes also place for -O0.'
Bernhard
--
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Maintenance
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2008-06-03 7:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 23:20 [PATCH] Fix implicit declaration of inb/outb Bernhard Walle
2008-06-03 1:43 ` Jamey Sharp
2008-06-03 7:33 ` Bernhard Walle
2008-06-12 2:09 ` Simon Horman
2008-06-03 7:36 ` Bernhard Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603093618.7974ffec@halley.suse.de \
--to=bwalle@suse.de \
--cc=jamey@thetovacompany.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox