Re: linux-next: build failure

From: Ankita Garg <ankita@in.ibm.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	kexec@lists.infradead.org, Haren Myneni <hbabu@us.ibm.com>,
	linux-next@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: linux-next: build failure
Date: Wed, 30 Jul 2008 12:36:43 +0530	[thread overview]
Message-ID: <20080730070643.GA18347@in.ibm.com> (raw)
In-Reply-To: <20080730064146.GA1564@cs181140183.pp.htv.fi>

On Wed, Jul 30, 2008 at 09:41:46AM +0300, Adrian Bunk wrote:
> On Wed, Jul 30, 2008 at 03:30:28PM +1000, Stephen Rothwell wrote:
> > Hi Ananth,
> > 
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> > 
> > tests/lkdtm.c:182: error: expected ')' before '*' token
> > 
> > I have no idea why this fails now when it did not before.
> 
> Sorry, that's my fault.
> (I didn't notice since my allyes builds have CONFIG_MODULES=n, and
>  no defconfig seems to have both LKDTM and IDE=y.)
> 
> Bart, can you either apply Stephen's patch or drop the lkdtm.c chunk 
> from my patch?
>

I suppose it would be better if the earlier changes are reverted, as
lkdtm already has bits to include ide.h depending on CONFIG_IDE being
y/n.

> > I applied the following patch.
> > -- 
> > Cheers,
> > Stephen Rothwell                    sfr@canb.auug.org.au
> > http://www.canb.auug.org.au/~sfr/
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 30 Jul 2008 15:24:53 +1000
> > Subject: [PATCH] tests: lkdtm needs ide.h
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  tests/lkdtm.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/tests/lkdtm.c b/tests/lkdtm.c
> > index 2a40d18..856f060 100644
> > --- a/tests/lkdtm.c
> > +++ b/tests/lkdtm.c
> > @@ -52,6 +52,7 @@
> >  #include <linux/init.h>
> >  #include <linux/interrupt.h>
> >  #include <linux/hrtimer.h>
> > +#include <linux/ide.h>
> >  #include <scsi/scsi_cmnd.h>
> >  
> >  #define NUM_CPOINTS 8
> 
> cu
> Adrian
> 
> -- 
> 
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed

-- 
Regards,
Ankita Garg (ankita@in.ibm.com)
Linux Technology Center
IBM India Systems & Technology Labs, 
Bangalore, India   

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec