From: Neil Horman <nhorman@redhat.com>
To: Indraneel Mukherjee <indro.ml@gmail.com>
Cc: kexec@lists.infradead.org
Subject: Re: Need for KEXEC_PRESERVE_CONTEXT flag ?
Date: Sun, 21 Jun 2009 13:17:09 -0400 [thread overview]
Message-ID: <20090621171709.GA3358@localhost.localdomain> (raw)
In-Reply-To: <48e37220906182330w6a6e83bctb3b3a27f7bfc6afb@mail.gmail.com>
On Fri, Jun 19, 2009 at 12:00:44PM +0530, Indraneel Mukherjee wrote:
> Hi,
>
> The file kernel/kexec.c (~ line 1001 in linux-2.6.30) has this code
>
> ------snip----
>
> if (flags & KEXEC_PRESERVE_CONTEXT)
> image->preserve_context = 1;
>
> ------snip----
>
> Will this ever be true? The flag KEXEC_PRESERVE_CONTEXT is not even defined
> in kexec-tools-2.0.0.
>
> Consequently, all the code inside the condition if(image->preserve_context)
> is also useless?
>
> Am i missing something here?
>
Yes, the code you're looking at in the first definition is part of the kernel,
while you're looking for the definition of KEXEC_PRESERVE_CONTEXT in the
kexec-tools userspace code. You need to look for the definition of
KEXEC_PRESERVE_CONTEXT in the kernel code (you'll find it in
include/linux/kexec.h). kexec-tools might use it one day, but not using it
doesn't mean we should remove it from the kernel.
Neil
> Regards,
> Indro
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2009-06-21 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 6:30 Need for KEXEC_PRESERVE_CONTEXT flag ? Indraneel Mukherjee
2009-06-21 17:17 ` Neil Horman [this message]
2009-06-21 18:54 ` Indraneel Mukherjee
2009-06-22 1:17 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090621171709.GA3358@localhost.localdomain \
--to=nhorman@redhat.com \
--cc=indro.ml@gmail.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox