From: Chris Wright <chrisw@sous-sol.org>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: nhorman@redhat.com, nhorman@tuxdriver.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
hbabu@us.ibm.com, iommu@lists.linux-foundation.org,
ebiederm@xmission.com, vgoyal@redhat.com
Subject: [PATCH 3/4] Revert "x86: disable IOMMUs on kernel crash"
Date: Fri, 02 Apr 2010 18:27:54 -0700 [thread overview]
Message-ID: <20100403012820.229410717@sous-sol.org> (raw)
In-Reply-To: 20100403012751.834020949@sous-sol.org
[-- Attachment #1: crash-leave-iommu-enabled.patch --]
[-- Type: text/plain, Size: 1161 bytes --]
This effectively reverts commit 61d047be99757fd9b0af900d7abce9a13a337488.
Disabling the IOMMU can potetially allow DMA transactions to
complete without being translated. Leave it enabled, and allow
crash kernel to do the IOMMU reinitialization properly.
Cc: Joerg Roedel <joerg.roedel@amd.com>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
---
arch/x86/kernel/crash.c | 6 ------
1 file changed, 6 deletions(-)
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -27,7 +27,6 @@
#include <asm/cpu.h>
#include <asm/reboot.h>
#include <asm/virtext.h>
-#include <asm/x86_init.h>
#if defined(CONFIG_SMP) && defined(CONFIG_X86_LOCAL_APIC)
@@ -103,10 +102,5 @@ void native_machine_crash_shutdown(struc
#ifdef CONFIG_HPET_TIMER
hpet_disable();
#endif
-
-#ifdef CONFIG_X86_64
- x86_platform.iommu_shutdown();
-#endif
-
crash_save_cpu(regs, safe_smp_processor_id());
}
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2010-04-03 1:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-03 1:27 [PATCH 0/4] AMD IOMMU kdump fix plus cleanups (v2) Chris Wright
2010-04-03 1:27 ` [PATCH 1/4] x86/amd-iommu: enable iommu before attaching devices Chris Wright
2010-04-03 1:27 ` [PATCH 2/4] x86/amd-iommu: warn when issuing command to uninitialized cmd buffer Chris Wright
2010-04-03 1:27 ` Chris Wright [this message]
2010-04-03 17:22 ` [PATCH 3/4] Revert "x86: disable IOMMUs on kernel crash" Joerg Roedel
2010-04-03 17:44 ` Eric W. Biederman
2010-04-04 8:44 ` Joerg Roedel
2010-04-04 9:16 ` Eric W. Biederman
2010-04-04 9:19 ` Eric W. Biederman
2010-04-03 17:41 ` Joerg Roedel
2010-04-03 17:49 ` Eric W. Biederman
2010-04-03 19:13 ` Joerg Roedel
2010-04-03 19:41 ` Eric W. Biederman
2010-04-04 7:24 ` Bernhard Walle
2010-04-04 7:51 ` Eric W. Biederman
2010-04-04 8:53 ` Joerg Roedel
2010-04-04 9:44 ` Eric W. Biederman
2010-04-04 10:01 ` Joerg Roedel
2010-04-06 17:42 ` Chris Wright
2010-04-06 17:51 ` Joerg Roedel
2010-04-06 20:39 ` Vivek Goyal
2010-04-06 21:13 ` Vivek Goyal
2010-04-06 21:45 ` Yinghai Lu
2010-04-06 22:10 ` Eric W. Biederman
2010-04-04 11:54 ` David Woodhouse
2010-04-03 1:27 ` [PATCH 4/4] x86/amd-iommu: use for_each_pci_dev Chris Wright
2010-04-07 10:05 ` [PATCH 0/4] AMD IOMMU kdump fix plus cleanups (v2) Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100403012820.229410717@sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=ebiederm@xmission.com \
--cc=hbabu@us.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox