public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Matt Evans <matt@ozlabs.org>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] kexec-tools: remove unused code from arch_process_options (arm, cris, ia64, mips, ppc)
Date: Thu, 13 May 2010 23:29:15 +0900	[thread overview]
Message-ID: <20100513142909.GA10534@verge.net.au> (raw)
In-Reply-To: <4BEBAF60.5000300@ozlabs.org>

On Thu, May 13, 2010 at 05:50:56PM +1000, Matt Evans wrote:
> Matt Evans wrote:
> > These architectures don't have any architecture-specific options
> > (note: distinct from loader options, which are more specific), yet
> > their arch_process_options() functions contain getopts_long() calls
> > followed by no argument processing.  The code doesn't do anything,
> > so this patch removes it.
> > 
> > Signed-off-by: Matt Evans <matt@ozlabs.org>
> > ---
> >  kexec/arch/arm/kexec-arm.c   |   17 -----------------
> >  kexec/arch/cris/kexec-cris.c |   17 -----------------
> >  kexec/arch/ia64/kexec-ia64.c |   21 +++------------------
> >  kexec/arch/mips/kexec-mips.c |   17 -----------------
> >  kexec/arch/ppc/kexec-ppc.c   |   17 -----------------
> >  5 files changed, 3 insertions(+), 86 deletions(-)
> 
> I forgot to add that unfortunately I have only been able to compile this
> patch on ppc.  Since the code carefully removed doesn't have any effect I
> am hopeful for the rest...  :-)

Thanks, applied.

I successfully compiled the code for the other architectures
with the exception of cris (as I don't have access to the box
with that cross compiler at the moment).

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2010-05-13 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13  7:33 [PATCH] kexec-tools: remove unused code from arch_process_options (arm, cris, ia64, mips, ppc) Matt Evans
2010-05-13  7:50 ` Matt Evans
2010-05-13 14:29   ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100513142909.GA10534@verge.net.au \
    --to=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=matt@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox