public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Neil Horman <nhorman@redhat.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	Simon Horman <horms@verge.net.au>,
	Andrew Vasquez <andrew.vasquez@qlogic.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-driver@qlogic.com, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: In place kexec
Date: Thu, 29 Jul 2010 12:55:35 -0700	[thread overview]
Message-ID: <20100729125535.85dfd7da.randy.dunlap@oracle.com> (raw)
In-Reply-To: <m1lj8uvzgy.fsf@fess.ebiederm.org>

On Thu, 29 Jul 2010 12:51:09 -0700 Eric W. Biederman wrote:

> Vivek Goyal <vgoyal@redhat.com> writes:
> 
> > On Thu, Jul 29, 2010 at 11:29:12AM -0700, H. Peter Anvin wrote:
> >> On 07/29/2010 11:06 AM, Eric W. Biederman wrote:
> >> > 
> >> > Thinking about this I am a bit surprised that you would find
> >> > DMA left on from a disk driver.  Historically disks have been
> >> > pretty good about shutting off in this scenario.
> >> > 
> >> > Added to that typically we unmount all filesystems.
> >> > 
> >> > Calling rmmod on the driver before the final kexec --exec
> >> > could be interesting, and drivers much more reliably implement
> >> > .remove than .shutdown.
> >> > 
> >> > Network drivers are more likely to be a problem, but we should be
> >> > downing all of the network interfaces before something happens.
> >> > 
> >> > All of which is to say kexec-in-place has generally been a lot
> >> > less hassle, because it is so similar to the normal case.
> >> > 
> >> 
> >> In particular, the supposed corruption comes from the "firmware logging"
> >> feature in the qla2xxx driver.  I'd really like to understand if this is
> >> a kexec problem or a qla2xxx problem.
> >> 	
> >
> > kernel_kexec()
> >    kernel_restart_prepare()
> > 	device_shutdown()
> >
> > I would suspect it to be a qla2xxx driver problem that it did not shut
> > down the device properly.
> 
> And device_shutdown calls every drivers .shutdown method.
> 
> Things like this are always a driver problem.


so is there a default .shutdown method for drivers that do not specify one?

like the qla2xxx driver does not.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2010-07-29 19:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 21:57 In place kexec H. Peter Anvin
2010-07-28 22:02 ` Eric W. Biederman
2010-07-29 13:43   ` Neil Horman
2010-07-29 15:03     ` H. Peter Anvin
2010-07-29 15:06       ` Neil Horman
2010-07-29 17:51         ` H. Peter Anvin
2010-07-29 18:06           ` Eric W. Biederman
2010-07-29 18:29             ` H. Peter Anvin
2010-07-29 19:16               ` Vivek Goyal
2010-07-29 19:51                 ` Eric W. Biederman
2010-07-29 19:55                   ` Randy Dunlap [this message]
2010-07-30  3:38                     ` H. Peter Anvin
2010-07-30  4:41                       ` Eric W. Biederman
2010-07-30  5:04                         ` H. Peter Anvin
2010-07-30 16:30                           ` Eric W. Biederman
2010-07-30 16:41                             ` H. Peter Anvin
2010-07-30 18:36                               ` Eric W. Biederman
2010-07-30 22:52                                 ` Andrew Vasquez
2010-07-30 23:25                                   ` H. Peter Anvin
2010-07-30 23:40                                     ` Eric W. Biederman
2010-07-30 16:53                         ` David Woodhouse
2010-07-30 18:21                           ` Eric W. Biederman
2010-07-30 18:34                             ` Vivek Goyal
2010-07-30 18:50                               ` David Woodhouse
2010-07-30 18:56                                 ` Vivek Goyal
2010-07-30 19:17                                   ` David Woodhouse
2010-07-30 19:39                                     ` Eric W. Biederman
2010-07-30 19:46                                       ` David Woodhouse
2010-07-30 20:08                                         ` Eric W. Biederman
2010-07-30 20:15                                           ` David Woodhouse
2010-07-30 21:11                                             ` H. Peter Anvin
2010-07-30 20:42                           ` H. Peter Anvin
2010-07-30 21:18                             ` Khalid Aziz
2010-07-30 21:44                               ` Khalid Aziz
     [not found]                                 ` <20120425211512.GA8583@ldl.usa.hp.com>
2012-04-25 22:06                                   ` Vivek Goyal
2010-07-29 20:06                   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100729125535.85dfd7da.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=ebiederm@xmission.com \
    --cc=horms@verge.net.au \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-driver@qlogic.com \
    --cc=nhorman@redhat.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox