From: Frederic Weisbecker <fweisbec@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>,
CAI Qian <caiqian@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
kexec <kexec@lists.infradead.org>,
viro@zeniv.linux.org.uk, jkacur@redhat.com, tglx@linutronix.de,
mingo@elte.hu, kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: fix /proc/vmcore seek
Date: Fri, 3 Sep 2010 23:10:55 +0200 [thread overview]
Message-ID: <20100903211052.GD5352@nowhere> (raw)
In-Reply-To: <20100903135844.133334ee.akpm@linux-foundation.org>
On Fri, Sep 03, 2010 at 01:58:44PM -0700, Andrew Morton wrote:
> On Thu, 2 Sep 2010 14:20:19 +0200
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > Commit 73296bc611 "procfs: Use generic_file_llseek in /proc/vmcore" broke
> > seeking on /proc/vmcore. This changes it back to use default_llseek
> > in order to restore the original behaviour.
>
> "broke" isn't a useful description of a bug :(
>
> A bit of list-trolling indicates that this change caused makedumpfile
> to hang during kexec dumping, yes? If so, why did this happen? How
> did the switch to generic_file_llseek() cause the /proc/vmcore seek
> behaviour to change?
>
> I'm not seeing a lot of difference between default_llseek() and
> generic_file_llseek() apart from file->f_mapping->host versus
> file->f_path.dentry->d_inode. Was it that, or what?
>
> etcetera. Better patch descriptions, please!
Yeah, that's the problem, we don't know yet why it broke. I was about
to investigate and try to find the problem before applying it but
got distracted by other things.
I'll try to find the issue.
Thanks.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2010-09-03 21:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <839326586.1621551283237394919.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-08-31 6:50 ` makedumpfile failed for 2.6.36-rc2 caiqian
2010-08-31 7:28 ` Ken'ichi Ohmichi
2010-08-31 8:29 ` CAI Qian
2010-09-01 4:33 ` Ken'ichi Ohmichi
2010-09-01 5:16 ` CAI Qian
2010-09-02 11:51 ` CAI Qian
2010-09-02 12:20 ` fix /proc/vmcore seek Arnd Bergmann
2010-09-02 14:23 ` CAI Qian
2010-09-03 1:00 ` Ken'ichi Ohmichi
2010-09-03 11:45 ` Arnd Bergmann
2010-09-03 20:58 ` Andrew Morton
2010-09-03 21:10 ` Frederic Weisbecker [this message]
2010-09-06 1:10 ` [PATCH][mmotm] unsigned offset llseek support (Was " KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100903211052.GD5352@nowhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=caiqian@redhat.com \
--cc=jkacur@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=mingo@elte.hu \
--cc=oomichi@mxs.nes.nec.co.jp \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox