From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <kexec-bounces+dwmw2=infradead.org@lists.infradead.org>
Received: from mx1.redhat.com ([209.132.183.28])
	by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux))
	id 1P5n9u-0003Wf-SF
	for kexec@lists.infradead.org; Tue, 12 Oct 2010 22:17:23 +0000
Date: Tue, 12 Oct 2010 18:17:17 -0400
From: Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [RFC PATCH] Bug during kexec...not all cpus are stopped
Message-ID: <20101012221717.GA27478@redhat.com>
References: <1286570087.8769.27.camel@ank32.eng.vmware.com>
	<1286816964.1372.2.camel@ank32.eng.vmware.com>
	<m1lj64ppri.fsf@fess.ebiederm.org>
	<1286826083.1372.15.camel@ank32.eng.vmware.com>
	<20101011213901.GR12743@redhat.com>
	<m1hbgs5qkc.fsf@fess.ebiederm.org>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <m1hbgs5qkc.fsf@fess.ebiederm.org>
List-Id: <kexec.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/kexec>,
	<mailto:kexec-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/kexec/>
List-Post: <mailto:kexec@lists.infradead.org>
List-Help: <mailto:kexec-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/kexec>,
	<mailto:kexec-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: kexec-bounces@lists.infradead.org
Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: jeremy@xensource.com, "kexec@lists.infradead.org" <kexec@lists.infradead.org>, the arch/x86 maintainers <x86@kernel.org>, Daniel Hecht <dhecht@vmware.com>, LKML <linux-kernel@vger.kernel.org>, Haren Myneni <hbabu@us.ibm.com>, Alok Kataria <akataria@vmware.com>

On Mon, Oct 11, 2010 at 03:10:11PM -0700, Eric W. Biederman wrote:
> Vivek Goyal <vgoyal@redhat.com> writes:
> 
> > On Mon, Oct 11, 2010 at 12:41:23PM -0700, Alok Kataria wrote:
> 
> > I don't think that kdump path uses smp_send_stop().
> 
> It doesn't.
> 
> > IIUC, on x86, we directly send NMI to other cpus.
> >
> > native_machine_crash_shutdown()
> >   kdump_nmi_shootdown_cpus()
> >         nmi_shootdown_cpus()
> >            smp_send_nmi_allbutself
> >                 apic->send_IPI_allbutself(NMI_VECTOR);
> >
> > So above description should be limited to only panic() path.
> 
> Is it actually confusing?  With respect to documenting the line
> of thinking it seems reasonable.
> 

No, just wanted to point out that let us modify the changelog to remove
keyword "kdump" from it. 

> > On a side note, I am wondering why panic() and kdump path can't share the
> > shutdown routine.
> 
> Hysterical raisins.  Andi's change to smp_send_stop says that NMIs not
> working on some boxes.  When someone wants to weed through all of the
> insanity it would probably be good to get the panic and the kdump paths
> sharing code.  For now simply separating panic and reboot should be
> enough, and it lets the code evolve where it needs to.
> 

Ok. Agreed that atleast conceptually kdump and panic() path should share
the code. But that's a different problem altogether and this patch can go in.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec