public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Per Fransson <per.fransson.ml@gmail.com>
Cc: kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] Add call to non-crashing cores through IPI
Date: Mon, 29 Nov 2010 11:47:05 -0600	[thread overview]
Message-ID: <20101129174705.GA25168@lixom.net> (raw)
In-Reply-To: <AANLkTinF0Ndb9-3z1ZeMBjPRH5jXWNA+BL6QpS+--0A4@mail.gmail.com>

On Mon, Nov 29, 2010 at 01:46:26PM +0100, Per Fransson wrote:
> >>  void machine_crash_shutdown(struct pt_regs *regs)
> >>  {
> >> +     unsigned long msecs;
> >
> > Int should be enough here? Not that it makes a difference on ARM, but
> > anyway. :)
> >
> >> +
> >>       local_irq_disable();
> >> +
> >> +     atomic_set(&waiting_for_crash_ipi, num_online_cpus() - 1);
> >> +     smp_call_function(machine_crash_nonpanic_core, NULL, false);
> >> +     msecs = 1000; /* Wait at most a second for the other cpus to stop */
> >> +     while ((atomic_read(&waiting_for_crash_ipi) > 0) && msecs) {
> >> +             mdelay(1);
> >> +             msecs--;
> >> +     }
> 
> The choice of type comes from the corresponding x86 code in
> 
>     arch/x86/kernel/reboot.c:nmi_shootdown_cpus()
> 
> Should we deviate?

We've already spent more time discussing this than it's worth. :-)
Leave it if you prefer.


-Olof

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2010-11-29 17:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24  8:28 [PATCH v2] Add call to non-crashing cores through IPI Per Fransson
2010-11-25  8:51 ` Mika Westerberg
2010-11-26  4:06 ` Olof Johansson
2010-11-29 12:46   ` Per Fransson
2010-11-29 17:47     ` Olof Johansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101129174705.GA25168@lixom.net \
    --to=olof@lixom.net \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=per.fransson.ml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox