Re: [RFC][PATCH] Add a sysctl option controlling kexec when MCE occurred

Borislav Petkov
2010-12-23T09:19:12Z

On Thu, Dec 23, 2010 at 08:43:39AM +0100, Andi Kleen wrote:
>
>
> > - Accessing to memory and dumping it to disks.
>
> A better solution for this is
>
> http://git.kernel.org/?p=linux/kernel/git/ak/linux-mce-2.6.git;a=commitdiff;h=fe61906edce9e70d02481a77a617ba1397573dce
> and
> http://git.kernel.org/?p=linux/kernel/git/ak/linux-mce-2.6.git;a=commit;h=cb58f049ae6709ddbab71be199390dc6852018cd
>
> I'm not a big friend of sysctls for things like this -- either the behaviour
> makes sense and should be default or not.

This doesn't add up. AFAICT, you're disabling MCE reporting for crash
dumps and the original patch's intention was to control whether kexec
should run after a machine check. And I agree with Greg that this
shouldn't be configurable but instead on by default - if you get a
critical error and you cannot guarantee a stable system anymore, kexec
shouldn't start at all. That simple.

Thanks.

--
Regards/Gruss,
Boris.