public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: Simon Horman <horms@verge.net.au>, kexec@lists.infradead.org
Subject: Re: [Patch] kexec: fix the missing i386 part in commit 1100580b05e
Date: Mon, 18 Apr 2011 08:58:02 -0400	[thread overview]
Message-ID: <20110418125802.GD30783@redhat.com> (raw)
In-Reply-To: <1303028945-15298-1-git-send-email-amwang@redhat.com>

On Sun, Apr 17, 2011 at 04:29:05PM +0800, Amerigo Wang wrote:
> Vivek pointed out that I missed the i386 part in this commit,
> 
> 	commit 1100580b05e3fdfe648d9be8617d962b11f4b88b
> 	Author: Amerigo Wang <amwang@redhat.com>
> 	Date:   Thu Mar 3 00:10:43 2011 +0800
> 
> 	    get the backup area dynamically
> 
> Yes. The customer who reported that bug definitely only
> tested it on x86_64. Now make it complete.

Hi Amerigo,

Have you verified the contents of backup area? I want to make sure that
everything is working and in second kernel when we read up vmcore, we
do read contents properly.

Thanks
Vivek

> 
> Signed-off-by: Amerigo Wang <amwang@redhat.com>
> Cc: Vivek Goyal <vgoyal@redhat.com>
> Cc: Simon Horman <horms@verge.net.au>
> 
> ---
> diff --git a/kexec/arch/i386/kexec-x86.c b/kexec/arch/i386/kexec-x86.c
> index 5c701aa..014ecd5 100644
> --- a/kexec/arch/i386/kexec-x86.c
> +++ b/kexec/arch/i386/kexec-x86.c
> @@ -184,6 +184,10 @@ void arch_update_purgatory(struct kexec_info *info)
>  		&arch_options.console_vga, sizeof(arch_options.console_vga));
>  	elf_rel_set_symbol(&info->rhdr, "console_serial",
>  		&arch_options.console_serial, sizeof(arch_options.console_serial));
> +	elf_rel_set_symbol(&info->rhdr, "backup_src_start",
> +		&info->backup_src_start, sizeof(info->backup_src_start));
> +	elf_rel_set_symbol(&info->rhdr, "backup_src_size",
> +		&info->backup_src_size, sizeof(info->backup_src_size));
>  	if (info->kexec_flags & KEXEC_ON_CRASH) {
>  		panic_kernel = 1;
>  		elf_rel_set_symbol(&info->rhdr, "backup_start",

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2011-04-18 12:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-17  8:29 [Patch] kexec: fix the missing i386 part in commit 1100580b05e Amerigo Wang
2011-04-18  7:59 ` Simon Horman
2011-04-18 12:58 ` Vivek Goyal [this message]
2011-04-19 12:47   ` Cong Wang
2011-04-19 16:20     ` Cong Wang
2011-04-19 16:53       ` Vivek Goyal
2011-04-20 10:52         ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110418125802.GD30783@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=amwang@redhat.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox