Re: [PATCH v2 7/8] makedumpfile: Add erased information in compressed kdump file

[Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>]

On 2011-08-19 15:16:59 Fri, Ken'ichi Ohmichi wrote:
> 
> Hi Mahesh,
> 
> Sorry about many responses of this patch.
> 
> On Wed, 18 May 2011 01:36:17 +0530
> Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> wrote:
> >
> > From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
> > 
> > Include the erase information in the makedumpfile generated dumpfile. The
> > erased information contains only effective lines from the filter
> > configuration file. This patch supports inclusion of erase information in
> > kdump compressed, flatten and split dumpfiles. On re-filtering, the erase
> > information from input dumpfile (if any) will be carried over to resulting
> > dumpfile.
> > 
> > This patch introduces new members offset_eraseinfo, size_eraseinfo into the
> > sub header in compressed kdump file.
> > 
> > The erased information would contain *multiple* erased symbol names.
> > For example, the following is based on your above example.
> > 
> > 	struct S1 {
> > 		int a;
> > 		int b;
> > 		int c;
> > 	};
> > 	struct S2 {
> > 		struct S1 *mystruct1;
> > 		struct S1 *mystruct2;
> > 	};
> > 
> > 	struct S2 mystruct2;
> > 
> > 	#Filter command
> > 	erase mystruct2.mystruct1.a
> > 	erase mystruct2.mystruct1.c
> > 	erase mystruct2.mystruct2.b
> > 
> > 	#The erased information
> > 	erase mystruct2.mystruct1.a 4
> > 	erase mystruct2.mystruct1.c 4
> > 	erase mystruct2.mystruct2.b 4
> 
> While testing this feature, I noticed the description format of
> makedumpfile.conf is different from the one of eraseinfo.
> The former contains "size", but the later does not.
> 
> Are there any reasons of different formats ?

There is no specific reason, since it is just an information I thought we
can follow a simple format.

> I feel the same format will be useful.

Sure, will make the change.

Thanks,
-Mahesh.

> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

-- 
Mahesh J Salgaonkar

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec