Re: [PATCH v2 00/14] Support Fujitsu Stand Alone Dump Format

tachibana
2011-10-31T00:03:41Z

Hi HATAYAMA-san

Thank you for updating patches.
I will review them.

Thanks.
tachibana

On 2011/10/28 18:48:04 +0900, HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:
> Hello Tachibana-san,
>
> Since there's certain time until Tachibana-san's review, I made some
> cleanups and bugfixes to the previous version. Could you review this
> instead to reduce the review time?
>
> ==
> The following series implements Fujitsu stand-alone dump (sadump)
> format support for makedumpfile, converting sadump-related formats
> into kdump-compressed format.
>
> Based on makedumpfile version 1.4.0.
>
> Here is summary of the changes.
>
> No debug information on sadump-related formats
> ==============================================
>
> Unlike other dump mechanisms, VMCORE created by sadump has NO debug
> information including VMCOREINFO. So, -x VMLINUX is definitely
> necessary.
>
> Debug information gained from VMLINUX is used for:
>
> 1. creating VMCOREINFO dynamically, saved in resulting dumpfiles
> in kdump-compressed format, and
>
> 2. gaining symbolic and type information necessary to refer to ELF
> note information contained in VMCORE generated by kdump at
> crash, and to estimate phys_base value.
>
> If no VMLINUX is specified, dumpfile with no VMCOREINFO and ELF note
> is generated on the current implementation.
>
>
> Command-line interface change
> =============================
>
> Introduce --diskset=VMCORE to pass multiple VMCOREs in a single
> commnad-line input.
>
> makedumpfile [OPTION] -x VMLINUX --diskset=VMCORE1 --diskset=VMCORE2 \
> [--diskset=VMCORE3 ..] DUMPFILE
>
>
> Architectures
> =============
>
> X86 and X86_64.
>
> On the other unsupported architectures, sadump-related source files
> are never compiled and linked into makedumpfile executable.
>
> ---
>
> HATAYAMA Daisuke (14):
> Add description of sadump-related formats in manual page
> Add description of sadump-related formts in usage information
> Read kexec backup region
> Procees CPUs based on online ones
> Generate and save VMCOREINFO and ELF note information
> Estimate phys_base based on linux_banner position
> Implement readmem() interface on sadump-related formats
> Initialize debug information for ELF note extraction
> Initialize internal data according to sadump-related formats
> Export helpers for bitmap table handling
> Verify and read VMCORE(s) in sadump-related formats
> Implement command-line processing
> Extend DumpInfo structure
> Add sadump module header file
>
>
> Makefile | 6
> elf_info.c | 2
> makedumpfile.8 | 22 +
> makedumpfile.c | 455 +++++++++++--
> makedumpfile.h | 207 ++++++
> print_info.c | 10
> sadump_info.c | 1945 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> sadump_info.h | 165 +++++
> sadump_mod.h | 186 +++++
> 9 files changed, 2907 insertions(+), 91 deletions(-)
> create mode 100644 sadump_info.c
> create mode 100644 sadump_info.h
> create mode 100644 sadump_mod.h
>
> --
> Thanks.
> HATAYAMA, Daisuke
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec