Re: [PATCH v2 10/14] Generate and save VMCOREINFO and ELF note information

Atsushi Kumagai
2011-12-20T08:21:50Z

Hi Hatayama-san,

> [snipped]
>
> diff --git a/elf_info.c b/elf_info.c
> index 114dd05..48f8510 100644
> --- a/elf_info.c
> +++ b/elf_info.c
> @@ -760,7 +760,7 @@ get_nr_cpus(void)
> int
> has_pt_note(void)
> {
> - if (offset_pt_note_memory && size_pt_note_memory)
> + if (offset_pt_note_memory || size_pt_note_memory)
> return TRUE;
> return FALSE;
> }

I have a question.
In what kind of case is only one of the offset or the size set to 0 in PT_NOTE?

Thanks.
Atsushi Kumagai

On Fri, 28 Oct 2011 18:48:58 +0900
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:

> Retrieve VMCOREINFO from VMLINUX and ELF note information from
> VMCORE(s) and save them in generated DUMPFILE.
>
> ELF note information is NT_PRSTATUS only. If crash_notes is NULL,
> indicating kdump has not saved register values, save SMRAM CPU STATE
> values. If crash_notes is not NULL, indicating kdump has saved
> register values at crash, then save the register values in
> crash_notes.
>
> Signed-off-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
> ---
>
> elf_info.c | 2
> makedumpfile.c | 103 ++++---
> makedumpfile.h | 2
> sadump_info.c | 823 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> sadump_info.h | 26 ++
> 5 files changed, 913 insertions(+), 43 deletions(-)
>
> [snipped]
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec