From: Will Deacon <will.deacon@arm.com>
To: Matthew Leach <matthew.leach@arm.com>
Cc: 'Simon Horman' <horms@verge.net.au>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM
Date: Thu, 6 Sep 2012 12:19:04 +0100 [thread overview]
Message-ID: <20120906111904.GF858@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <000101cd8c1f$6f758520$4e608f60$@leach@arm.com>
On Thu, Sep 06, 2012 at 12:04:50PM +0100, Matthew Leach wrote:
> I believe that you are loading the dtb at an offset from the base
> of 0x1000, this is where the problem lies in that the dtb can be
> corrupted by the page tables of the decompressor.
Aha, so it is still using the KEXEC_ARM_ATAGS_OFFSET stuff. Sorry if I
confused anybody about the DTB-append comments, I guess I was confusing the
segment layout with the final loaded layout.
It's worth pointing out that, with LPAE kernels, the page tables are larger
and sit at offset 0x3000, so this leaves only 8k for the .dtb which is
definitely not enough.
> I suggest that we put the DTB out of the way, perhaps just after
> the initrd segment, or at the initrd_offset in the case that
> there is no initrd. This would require a kernel change to set the
> correct parameter to the relocate_new_kerenel function, but the
> change is minimal.
I'm fine with changing the kernel, as long as it doesn't break existing
users (it doesn't).
Will
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2012-09-06 11:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 11:43 [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM Matthew Leach
2012-09-05 11:44 ` [RFC PATCH 1/4] Fix an overflow bug with address comparison Matthew Leach
2012-09-05 11:44 ` [RFC PATCH 2/4] Move libfdt to a generic location Matthew Leach
2012-09-05 11:44 ` [RFC PATCH 3/4] Add the dtc for device-tree manipulation Matthew Leach
2012-09-05 11:44 ` [RFC PATCH 4/4] Add device tree support to the ARM platform Matthew Leach
2012-09-05 12:38 ` [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM Simon Horman
2012-09-05 14:34 ` Matthew Leach
2012-09-06 3:29 ` Simon Horman
2012-09-06 9:01 ` Will Deacon
2012-09-06 9:09 ` Simon Horman
2012-09-06 9:14 ` Will Deacon
2012-09-06 22:03 ` Simon Horman
2012-09-06 11:04 ` Matthew Leach
2012-09-06 11:19 ` Will Deacon [this message]
2012-09-06 22:00 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906111904.GF858@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=matthew.leach@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox