From: Simon Horman <horms@verge.net.au>
To: Dave Young <dyoung@redhat.com>
Cc: Kexec Mailing List <kexec@lists.infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH][V2] vmcore-dmesg: Determine correct machine pointer size
Date: Thu, 15 Nov 2012 08:19:18 +0900 [thread overview]
Message-ID: <20121114231917.GI15960@verge.net.au> (raw)
In-Reply-To: <50A34A83.1030901@redhat.com>
On Wed, Nov 14, 2012 at 03:38:43PM +0800, Dave Young wrote:
> On 11/14/2012 12:38 AM, Vivek Goyal wrote:
>
> > A 32bit arch can prepare ELF64 headers. For example for PAE case to
> > preresent file offsets 64bit but data size at the offset still remains
> > 32bit. If we just base our decision based on EI_CLASS, then we will try
> > to read 64bit data from file and can run into various issues.
> >
> > We ran into following issue when we tried to run vmcore-dmesg on a 32bit
> > PAE system vmcore which had 64bit elf headers.
> >
> > No program header covering vaddr 0xc0a6a688c0b89100found kexec bug?
> >
> > Basically we try to read value of log_buf variable from address
> > log_buf_vaddr. We read in 64bit value and then pass that value again
> > to vaddr_to_offset() in an attempt to get to actual log_buf start
> > and get error message.
> >
> > So determine the machine pointer size based on ELF class and arch and read
> > the bytes from file accordingly.
> >
> > v2: Fixed the code as per suggestion from Eric.
> >
> > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
>
>
> Ack
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2012-11-14 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 16:38 [PATCH][V2] vmcore-dmesg: Determine correct machine pointer size Vivek Goyal
2012-11-14 4:13 ` Eric W. Biederman
2012-11-14 7:38 ` Dave Young
2012-11-14 23:19 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114231917.GI15960@verge.net.au \
--to=horms@verge.net.au \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox