From: Simon Horman <horms@verge.net.au>
To: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] kexec: fix wrong types of some local variables
Date: Fri, 1 Mar 2013 10:31:56 +0900 [thread overview]
Message-ID: <20130301013156.GA11434@verge.net.au> (raw)
In-Reply-To: <512C44E4.70907@cn.fujitsu.com>
On Tue, Feb 26, 2013 at 01:15:16PM +0800, Zhang Yanfei wrote:
> The types of the following local variables:
> - ubytes/mbytes in kimage_load_crash_segment()/kimage_load_normal_segment()
> - r in vmcoreinfo_append_str()
> are wrong, so fix them.
>
> Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Simon Horman <horms@verge.net.au>
> Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
No complaints here.
Reviewed-by: Simon Horman <horms@verge.net.au>
> ---
> kernel/kexec.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 2436ffc..3cbfcc7 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -789,7 +789,7 @@ static int kimage_load_normal_segment(struct kimage *image,
> struct kexec_segment *segment)
> {
> unsigned long maddr;
> - unsigned long ubytes, mbytes;
> + size_t ubytes, mbytes;
> int result;
> unsigned char __user *buf;
>
> @@ -853,7 +853,7 @@ static int kimage_load_crash_segment(struct kimage *image,
> * We do things a page at a time for the sake of kmap.
> */
> unsigned long maddr;
> - unsigned long ubytes, mbytes;
> + size_t ubytes, mbytes;
> int result;
> unsigned char __user *buf;
>
> @@ -1455,7 +1455,7 @@ void vmcoreinfo_append_str(const char *fmt, ...)
> {
> va_list args;
> char buf[0x50];
> - int r;
> + size_t r;
>
> va_start(args, fmt);
> r = vsnprintf(buf, sizeof(buf), fmt, args);
> --
> 1.7.1
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2013-03-01 1:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 5:15 [PATCH v3 1/2] kexec: fix wrong types of some local variables Zhang Yanfei
2013-02-26 5:30 ` [PATCH v3 2/2] kexec: Use min_t to simplify logic Zhang Yanfei
2013-02-26 8:38 ` Joe Perches
2013-02-26 8:49 ` Zhang Yanfei
2013-02-26 8:53 ` Andrew Morton
2013-02-26 8:55 ` Zhang Yanfei
2013-02-27 22:31 ` Andrew Morton
2013-03-01 1:31 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301013156.GA11434@verge.net.au \
--to=horms@verge.net.au \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox