public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] kexec/s390: Replace clgfi with cghi
Date: Fri, 15 Mar 2013 16:57:33 +0100	[thread overview]
Message-ID: <20130315155732.GF16561@verge.net.au> (raw)
In-Reply-To: <20130315134632.1177a239@holzheu>

On Fri, Mar 15, 2013 at 01:46:32PM +0100, Michael Holzheu wrote:
> The clgfi instruction needs at least z9 machine level. To allow kexec-tools
> compiled also with z900, this patch replaces clgfi with the older cghi
> instruction.

Hi,

could you update the changelog to include a brief description of the
difference between the two instructions - I assume they work the same
way in the context of this change.

> Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> ---
>  purgatory/arch/s390/setup-s390.S |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: kexec-tools-2.0.3/purgatory/arch/s390/setup-s390.S
> ===================================================================
> --- kexec-tools-2.0.3.orig/purgatory/arch/s390/setup-s390.S
> +++ kexec-tools-2.0.3/purgatory/arch/s390/setup-s390.S
> @@ -16,7 +16,7 @@ purgatory_start:
>  	larl	%r15,lstack_end
>  	aghi	%r15,-160
>  
> -	clgfi	%r2,0
> +	cghi	%r2,0
>  	je	verify_checksums
>  
>  	brasl	%r14,purgatory
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2013-03-15 15:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 12:46 [PATCH] kexec/s390: Replace clgfi with cghi Michael Holzheu
2013-03-15 15:57 ` Simon Horman [this message]
2013-03-15 17:25   ` Michael Holzheu
2013-03-15 20:08     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130315155732.GF16561@verge.net.au \
    --to=horms@verge.net.au \
    --cc=holzheu@linux.vnet.ibm.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox