From: Andrew Morton <akpm@linux-foundation.org>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: kexec@lists.infradead.org, heiko.carstens@de.ibm.com,
linux-kernel@vger.kernel.org, lisa.mitchell@hp.com,
kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com,
zhangyanfei@cn.fujitsu.com, cpw@sgi.com, vgoyal@redhat.com
Subject: Re: [PATCH v3 07/21] vmcore, procfs: introduce a flag to distinguish objects copied in 2nd kernel
Date: Tue, 19 Mar 2013 12:35:31 -0700 [thread overview]
Message-ID: <20130319123531.9777a366ff0e1611727405cd@linux-foundation.org> (raw)
In-Reply-To: <20130316040126.15064.67305.stgit@localhost6.localdomain6>
On Sat, 16 Mar 2013 13:01:26 +0900 HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:
> The part of dump target memory is copied into the 2nd kernel if it
> doesn't satisfy mmap()'s page-size boundary requirement. To
> distinguish such copied object from usual old memory, a flag
> MEM_TYPE_CURRENT_KERNEL is introduced. If this flag is set, the object
> is considered being copied into buffer on the 2nd kernel.
>
I don't understand this description at all :( Perhaps we can have a
lengthier version which expands on the concepts a bit further?
> --- a/include/linux/proc_fs.h
> +++ b/include/linux/proc_fs.h
> @@ -97,11 +97,17 @@ struct kcore_list {
> int type;
> };
>
> +#define MEM_TYPE_CURRENT_KERNEL 0x1
A comment describing this would be useful.
> struct vmcore {
> struct list_head list;
> - unsigned long long paddr;
> + union {
> + unsigned long long paddr;
> + char *buf;
> + };
This change wasn't described in the changelog?
> unsigned long long size;
> loff_t offset;
> + unsigned int flag;
Presumably this is the place where we put MEM_TYPE_CURRENT_KERNEL?
That's unobvious from reading the code. Add the text "vmcore.flag
fields:" above the MEM_TYPE_CURRENT_KERNEL definition.
> };
>
> #ifdef CONFIG_PROC_FS
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-03-19 19:35 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 4:00 [PATCH v3 00/21] kdump, vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-03-16 4:00 ` [PATCH v3 01/21] vmcore: reference e_phoff member explicitly to get position of program header table HATAYAMA Daisuke
2013-03-19 21:44 ` Eric W. Biederman
2013-03-21 2:50 ` HATAYAMA Daisuke
2013-03-21 6:11 ` Eric W. Biederman
2013-03-21 14:12 ` Vivek Goyal
2013-03-22 0:25 ` HATAYAMA Daisuke
2013-03-16 4:00 ` [PATCH v3 02/21] vmcore: clean up by removing unnecessary variable HATAYAMA Daisuke
2013-03-16 4:01 ` [PATCH v3 03/21] vmcore: rearrange program headers without assuming consequtive PT_NOTE entries HATAYAMA Daisuke
2013-03-19 21:59 ` Eric W. Biederman
2013-03-16 4:01 ` [PATCH v3 04/21] vmcore, sysfs: export ELF note segment size instead of vmcoreinfo data size HATAYAMA Daisuke
2013-03-16 4:01 ` [PATCH v3 05/21] vmcore: allocate buffer for ELF headers on page-size alignment HATAYAMA Daisuke
2013-03-16 4:01 ` [PATCH v3 06/21] vmcore: round up buffer size of ELF headers by PAGE_SIZE HATAYAMA Daisuke
2013-03-19 22:07 ` Eric W. Biederman
2013-03-16 4:01 ` [PATCH v3 07/21] vmcore, procfs: introduce a flag to distinguish objects copied in 2nd kernel HATAYAMA Daisuke
2013-03-19 19:35 ` Andrew Morton [this message]
2013-03-16 4:01 ` [PATCH v3 08/21] vmcore: copy non page-size aligned head and tail pages " HATAYAMA Daisuke
2013-03-19 19:37 ` Andrew Morton
2013-03-19 20:59 ` Eric W. Biederman
2013-03-19 21:22 ` Vivek Goyal
2013-03-19 23:35 ` Eric W. Biederman
2013-03-16 4:01 ` [PATCH v3 09/21] vmcore: modify vmcore clean-up function to free buffer on " HATAYAMA Daisuke
2013-03-16 4:01 ` [PATCH v3 10/21] vmcore: clean up read_vmcore() HATAYAMA Daisuke
2013-03-16 4:01 ` [PATCH v3 11/21] vmcore: read buffers for vmcore objects copied from old memory HATAYAMA Daisuke
2013-03-16 4:01 ` [PATCH v3 12/21] vmcore: allocate per-cpu crash_notes objects on page-size boundary HATAYAMA Daisuke
2013-03-19 21:06 ` Eric W. Biederman
2013-03-19 22:12 ` Eric W. Biederman
2013-03-20 13:48 ` Vivek Goyal
2013-03-20 20:48 ` Eric W. Biederman
2013-03-16 4:02 ` [PATCH v3 13/21] kexec: allocate vmcoreinfo note buffer " HATAYAMA Daisuke
2013-03-19 21:07 ` Eric W. Biederman
2013-03-19 22:12 ` Eric W. Biederman
2013-03-16 4:02 ` [PATCH v3 14/21] kexec, elf: introduce NT_VMCORE_DEBUGINFO note type HATAYAMA Daisuke
2013-03-16 4:02 ` [PATCH v3 15/21] elf: introduce NT_VMCORE_PAD type HATAYAMA Daisuke
2013-03-16 4:02 ` [PATCH v3 16/21] kexec: fill note buffers by NT_VMCORE_PAD notes in page-size boundary HATAYAMA Daisuke
2013-03-19 22:17 ` Eric W. Biederman
2013-03-16 4:02 ` [PATCH v3 17/21] vmcore: check NT_VMCORE_PAD as a mark indicating the end of ELF note buffer HATAYAMA Daisuke
2013-03-19 21:11 ` Eric W. Biederman
2013-03-21 2:59 ` HATAYAMA Daisuke
2013-03-21 3:54 ` Eric W. Biederman
2013-03-21 14:36 ` Vivek Goyal
2013-03-22 0:30 ` HATAYAMA Daisuke
2013-03-22 0:41 ` Eric W. Biederman
2013-03-19 22:20 ` Eric W. Biederman
2013-03-16 4:02 ` [PATCH v3 18/21] vmcore: check if vmcore objects satify mmap()'s page-size boundary requirement HATAYAMA Daisuke
2013-03-19 20:02 ` Andrew Morton
2013-03-19 21:22 ` Eric W. Biederman
2013-03-20 13:51 ` Vivek Goyal
2013-03-19 22:38 ` Eric W. Biederman
2013-03-20 13:57 ` Vivek Goyal
2013-03-20 20:55 ` Eric W. Biederman
2013-03-21 3:25 ` HATAYAMA Daisuke
2013-03-21 4:18 ` Eric W. Biederman
2013-03-21 6:14 ` HATAYAMA Daisuke
2013-03-21 6:29 ` Eric W. Biederman
2013-03-21 6:46 ` HATAYAMA Daisuke
2013-03-21 7:07 ` Eric W. Biederman
2013-03-21 15:21 ` Vivek Goyal
2013-03-21 15:27 ` Vivek Goyal
2013-03-22 0:43 ` HATAYAMA Daisuke
2013-03-22 0:54 ` Eric W. Biederman
2013-03-22 2:30 ` HATAYAMA Daisuke
2013-03-21 14:57 ` Vivek Goyal
2013-03-21 7:22 ` Eric W. Biederman
2013-03-21 14:49 ` Vivek Goyal
2013-03-22 7:11 ` HATAYAMA Daisuke
2013-03-21 13:50 ` Vivek Goyal
2013-03-16 4:02 ` [PATCH v3 19/21] vmcore: round-up offset of vmcore object in page-size boundary HATAYAMA Daisuke
2013-03-16 4:02 ` [PATCH v3 20/21] vmcore: count holes generated by round-up operation for vmcore size HATAYAMA Daisuke
2013-03-16 4:02 ` [PATCH v3 21/21] vmcore: introduce mmap_vmcore() HATAYAMA Daisuke
2013-03-19 19:30 ` [PATCH v3 00/21] kdump, vmcore: support mmap() on /proc/vmcore Andrew Morton
2013-03-21 3:52 ` HATAYAMA Daisuke
2013-03-21 6:16 ` Eric W. Biederman
2013-03-21 6:35 ` HATAYAMA Daisuke
2013-03-21 7:14 ` Eric W. Biederman
2013-03-19 23:16 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319123531.9777a366ff0e1611727405cd@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cpw@sgi.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=ebiederm@xmission.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa.mitchell@hp.com \
--cc=vgoyal@redhat.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox