public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Zhang Yanfei <zhangyanfei.yes@gmail.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH 2/2] kexec: Use err() instead of fprintf()
Date: Wed, 27 Mar 2013 21:43:17 +0900	[thread overview]
Message-ID: <20130327124316.GA17248@verge.net.au> (raw)
In-Reply-To: <51506B8F.2090106@gmail.com>

On Mon, Mar 25, 2013 at 11:21:51PM +0800, Zhang Yanfei wrote:
> 于 2013年03月20日 21:21, Simon Horman 写道:
> > On Wed, Mar 20, 2013 at 09:17:51PM +0800, Zhang Yanfei wrote:
> >> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> >>
> >> Since we have the err() interface, so replace the error printing
> >> function with err().
> > 
> > This patch introduces a lot of code changes and I'm not entirely
> > sure that I see the benefit.
> 
> Sorry for the long patch.
> 
> I just wanted to use a simpler error displaying function instead of
> fprintf(stderr, ...). Just like we use die() or dbgprintf. If you
> think this is unnecessary, just ignore the patch please.

I think that I would prefer to not accept this patch at this time.
Thanks all the same.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2013-03-27 12:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 13:15 [PATCH 1/2] kexec: Add new interface for printing error messages Zhang Yanfei
2013-03-20 13:17 ` [PATCH 2/2] kexec: Use err() instead of fprintf() Zhang Yanfei
2013-03-20 13:21   ` Simon Horman
2013-03-25 15:21     ` Zhang Yanfei
2013-03-27 12:43       ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130327124316.GA17248@verge.net.au \
    --to=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=zhangyanfei.yes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox