From: Daniel Kiper <daniel.kiper@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Simon Horman <horms@verge.net.au>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 5/5] kexec/xen: directly load images images into Xen
Date: Wed, 17 Apr 2013 16:12:05 +0200 [thread overview]
Message-ID: <20130417141205.GD906@debian70-amd64.local.net-space.pl> (raw)
In-Reply-To: <516EA95D.8010200@citrix.com>
On Wed, Apr 17, 2013 at 02:53:33PM +0100, David Vrabel wrote:
> On 17/04/13 13:56, Daniel Kiper wrote:
> > On Tue, Apr 09, 2013 at 11:20:36PM +0200, Daniel Kiper wrote:
> >>
> >> arch = (kexec_flags & KEXEC_ARCH_MASK) >> 16;
> >
> > What is wrong with this line?
> > Why did not you applied it?
>
> I haven't reposted the kexec-tools patches so it's not clear what you
> are expecting this to be applied to.
arch = (kexec_flags >> 16) & 0xffff;
should be changed to:
arch = (kexec_flags & KEXEC_ARCH_MASK) >> 16;
or add comment what are you doing but I think
that former is better.
Additionally I found in kexec-tools git tree something like that:
kexec/crashdump-xen.c:
...
#ifdef HAVE_LIBXENCTRL
int get_xen_vmcoreinfo(uint64_t *addr, uint64_t *len)
{
...
}
and in
kexec/crashdump.c:
...
#ifndef HAVE_LIBXENCTRL
int get_xen_vmcoreinfo(uint64_t *addr, uint64_t *len)
{
return get_vmcoreinfo("/sys/hypervisor/vmcoreinfo", addr, len);
}
#endif
Move get_xen_vmcoreinfo() from kexec/crashdump.c to kexec/crashdump-xen.c
and make it return -1 ifndef HAVE_LIBXENCTRL. /sys/hypervisor/vmcoreinfo
is valid for legacy kexec implementation only.
Please repost next time Xen and kexec-tools patches.
Daniel
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-04-17 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 19:06 [PATCHv2 0/4] kexec-tools: add support for Xen 4.3 David Vrabel
2013-04-08 19:06 ` [PATCH 1/5] purgatory: put variables altered by kexec in .data not .bss David Vrabel
2013-04-08 19:06 ` [PATCH 2/5] kexec/xen: require libxc from Xen 4.3 David Vrabel
2013-04-08 19:06 ` [PATCH 3/5] kexec/xen: use libxc to get location of crash notes David Vrabel
2013-04-08 19:06 ` [PATCH 4/5] kexec/xen: switch to use xc_kexec_get_range for get_xen_vmcoreinfo David Vrabel
2013-04-08 19:06 ` [PATCH 5/5] kexec/xen: directly load images images into Xen David Vrabel
2013-04-09 21:20 ` Daniel Kiper
2013-04-17 12:56 ` Daniel Kiper
2013-04-17 13:53 ` David Vrabel
2013-04-17 14:12 ` Daniel Kiper [this message]
2013-04-09 2:49 ` [PATCHv2 0/4] kexec-tools: add support for Xen 4.3 Simon Horman
2013-04-09 21:16 ` Daniel Kiper
-- strict thread matches above, loose matches on Subject: below --
2013-09-12 20:00 [PATCHv4 0/5] " David Vrabel
2013-09-12 20:00 ` [PATCH 5/5] kexec/xen: directly load images images into Xen David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130417141205.GD906@debian70-amd64.local.net-space.pl \
--to=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox