From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UcGYn-0000JW-Il for kexec@lists.infradead.org; Tue, 14 May 2013 14:50:38 +0000 Date: Tue, 14 May 2013 10:50:03 -0400 From: Vivek Goyal Subject: Re: [PATCH v5 3/8] vmalloc: make find_vm_area check in range Message-ID: <20130514145003.GC16772@redhat.com> References: <20130514015622.18697.77191.stgit@localhost6.localdomain6> <20130514015723.18697.34468.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130514015723.18697.34468.stgit@localhost6.localdomain6> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: HATAYAMA Daisuke Cc: Rik Van Riel , Hugh Dickins , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, lisa.mitchell@hp.com, linux-mm@kvack.org, kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com, zhangyanfei@cn.fujitsu.com, akpm@linux-foundation.org, Michel Lespinasse , cpw@sgi.com, jingbai.ma@hp.com On Tue, May 14, 2013 at 10:57:23AM +0900, HATAYAMA Daisuke wrote: > Currently, __find_vmap_area searches for the kernel VM area starting > at a given address. This patch changes this behavior so that it > searches for the kernel VM area to which the address belongs. This > change is needed by remap_vmalloc_range_partial to be introduced in > later patch that receives any position of kernel VM area as target > address. > > This patch changes the condition (addr > va->va_start) to the > equivalent (addr >= va->va_end) by taking advantage of the fact that > each kernel VM area is non-overlapping. > > Signed-off-by: HATAYAMA Daisuke This will require ack from mm folks. CCing some of them. Thanks Vivek > --- > > mm/vmalloc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index d365724..3875fa2 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -292,7 +292,7 @@ static struct vmap_area *__find_vmap_area(unsigned long addr) > va = rb_entry(n, struct vmap_area, rb_node); > if (addr < va->va_start) > n = n->rb_left; > - else if (addr > va->va_start) > + else if (addr >= va->va_end) > n = n->rb_right; > else > return va; _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec