Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
To: Maxim Uvarov <muvarov@gmail.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	Jan Willeke <willeke@de.ibm.com>,
	linux-kernel@vger.kernel.org,
	HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()
Date: Mon, 10 Jun 2013 10:00:00 +0200	[thread overview]
Message-ID: <20130610100000.23743ea1@holzheu> (raw)
In-Reply-To: <CAJGZr0+_W0dp2f9VtVAiUT2fqiwe91gHXd9zYzfMMzBZSZogww@mail.gmail.com>

On Sat, 8 Jun 2013 11:38:00 +0400
Maxim Uvarov <muvarov@gmail.com> wrote:

[snip]

> > +static int copy_to(void *target, void *src, size_t size, int
> > userbuf) +{
> > +       if (userbuf) {
> > +               if (copy_to_user(target, src, size))
> > +                       return -EFAULT;
> > +               return 0;
> > +       } else {
> > +               memcpy(target, src, size);
> > +               return 0;
> > +       }
> > +}
> >  
> 
> It is better to do return 0 in the end of function.

Sure, I will change that.

Thanks!
Michael

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec