From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Stephen Warren <swarren@nvidia.com>,
kexec@lists.infradead.org, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Simon Horman <horms@verge.net.au>,
ebiederm@xmission.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: kexec: validate CPU hotplug support
Date: Thu, 1 Aug 2013 14:41:19 +0100 [thread overview]
Message-ID: <20130801134119.GG24642@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1373582931-11956-1-git-send-email-swarren@wwwdotorg.org>
On Thu, Jul 11, 2013 at 04:48:51PM -0600, Stephen Warren wrote:
> +int platform_can_cpu_hotplug(void)
> +{
> + if (!IS_ENABLED(CONFIG_HOTPLUG_CPU) || !smp_ops.cpu_kill)
> + return 0;
This is an inappropriate usage of IS_ENABLED(). When hotplug CPU is
disabled, there is no cpu_kill member in smp_ops, so this leads to
build failure.
Dropping your patch.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2013-08-01 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 22:48 [PATCH] ARM: kexec: validate CPU hotplug support Stephen Warren
2013-07-19 15:18 ` Stephen Warren
2013-07-30 21:40 ` Stephen Warren
2013-07-21 1:40 ` Eric W. Biederman
2013-08-01 13:41 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801134119.GG24642@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox