From: WANG Chao <chaowang@redhat.com>
To: Cliff Wickman <cpw@sgi.com>
Cc: kexec@lists.infradead.org, d.hatayama@jp.fujitsu.com,
kumagai-atsushi@mxc.nes.nec.co.jp
Subject: Re: [PATCH] makedumpfile: reverse -c and -p if using snappy compression
Date: Thu, 29 Aug 2013 10:58:37 +0800 [thread overview]
Message-ID: <20130829025837.GA2298@dhcp12-158.nay.redhat.com> (raw)
In-Reply-To: <E1VEnuJ-0000Js-Gl@eag09.americas.sgi.com>
Hi, Cliff
On 08/28/13 at 05:08pm, Cliff Wickman wrote:
> From: Cliff Wickman <cpw@sgi.com>
>
> Reverse the meanings of -c (compression) and -p (snappy compression) if
> USESNAPPY is defined.
>
> The distro kdump scripts seem to only support -c for compression.
> So make -c mean snappy compression if it is supported.
It looks like more a distro issue to me. I'm wondering if that script
only support -c, why do that distro compile makedumpfile with USESNAPPY?
I don't think other distros would like to see this change. IMHO, the
right thing to do is fix that kdump script on that particular distro,
not reverse -c and -p.
Thanks
WANG Chao
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-08-29 2:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 22:08 [PATCH] makedumpfile: reverse -c and -p if using snappy compression Cliff Wickman
2013-08-29 2:58 ` WANG Chao [this message]
2013-08-29 18:46 ` Cliff Wickman
2013-08-30 10:33 ` WANG Chao
2013-09-10 7:29 ` Atsushi Kumagai
2013-08-30 3:34 ` Baoquan He
2013-08-30 9:52 ` Maxim Uvarov
2013-09-10 7:29 ` Atsushi Kumagai
2013-09-10 8:25 ` Maxim Uvarov
2013-09-10 9:57 ` HATAYAMA Daisuke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829025837.GA2298@dhcp12-158.nay.redhat.com \
--to=chaowang@redhat.com \
--cc=cpw@sgi.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox