public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: WANG Chao <chaowang@redhat.com>
To: kexec@lists.infradead.org
Cc: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: [PATCH] Remove PACKED macro and use __attribute__((packed)) directly
Date: Thu, 5 Sep 2013 17:21:21 +0800	[thread overview]
Message-ID: <20130905092121.GA8560@dhcp12-158.nay.redhat.com> (raw)

People are not always aware of PACKED macro and tend to
__attribute__((packed)) more directly. So let's remove PACKED to unify
things.

Signed-off-by: WANG Chao <chaowang@redhat.com>
---
 include/x86/x86-linux.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/include/x86/x86-linux.h b/include/x86/x86-linux.h
index 0949dc2..c41e5f2 100644
--- a/include/x86/x86-linux.h
+++ b/include/x86/x86-linux.h
@@ -12,8 +12,6 @@
 
 #ifndef ASSEMBLY
 
-#define PACKED __attribute__((packed))
-
 #ifndef E820_RAM
 struct e820entry {
 	uint64_t addr;	/* start of memory segment */
@@ -23,7 +21,7 @@ struct e820entry {
 #define E820_RESERVED	2
 #define E820_ACPI	3 /* usable as RAM once ACPI tables have been read */
 #define E820_NVS	4
-} PACKED;
+} __attribute__((packed));
 #endif
 
 /* FIXME expand on drive_info_)struct... */
@@ -255,7 +253,7 @@ struct x86_linux_header {
 	uint64_t pref_address;			/* 0x258 */
 	uint32_t init_size;			/* 0x260 */
 	uint32_t handover_offset;		/* 0x264 */
-} PACKED;
+} __attribute__((packed));
 
 #endif /* ASSEMBLY */
 
-- 
1.8.3.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

             reply	other threads:[~2013-09-05  9:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05  9:21 WANG Chao [this message]
2013-10-16  7:12 ` [PATCH] Remove PACKED macro and use __attribute__((packed)) directly Simon Horman
2013-10-16  7:14   ` Zhang Yanfei
2013-10-16  7:17     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130905092121.GA8560@dhcp12-158.nay.redhat.com \
    --to=chaowang@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox