Re: [PATCH 15/16] bootparam: Pass acpi_rsdp pointer in bootparam

Dave Young
2013-09-12T07:35:01Z

On 09/11/13 at 04:32pm, Borislav Petkov wrote:
> On Wed, Sep 11, 2013 at 09:45:34AM -0400, Vivek Goyal wrote:
> > I am looking forward to that new version. CCing Dave Young. He is also
> > looking into it and going through history of patches.
>
> Ok, I'll CC you guys on the submission - I'd need any and all feedback I
> can get on that topic.

I'm playing with skipping SetVirtualAddressMap in kexec kernel, for same kernel
the test result is ok for me both for kexec and kdump. Takao Indoh sent a patch
with this approatch, but his V2 switched to use physical mapping.
During my test, additional data of config table elems need to be saved besides of
fw_vendor, runtime and tables or dereference taglep->guid will panic.

Also kexec userspace need to fill efi_info in bootparams and pass the previous
saved efi data to 2nd kernel.

I'm worrying just skiping enter virt mode have risk though it's an easy solution.
Your 1:1 mapping approatch looks better. I look forward to test your new patchset.
Are you also working on kexec userspace part? Already have a patch?

>
> Thanks.
>
> --
> Regards/Gruss,
> Boris.