From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from userp1040.oracle.com ([156.151.31.81]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VLY9R-0003BO-8g for kexec@lists.infradead.org; Mon, 16 Sep 2013 12:43:37 +0000 Date: Mon, 16 Sep 2013 14:43:02 +0200 From: Daniel Kiper Subject: Re: [PATCH 1/5] purgatory: put variables altered by kexec in .data not .bss Message-ID: <20130916124302.GC14630@debian70-amd64.local.net-space.pl> References: <1379016042-22510-1-git-send-email-david.vrabel@citrix.com> <1379016042-22510-2-git-send-email-david.vrabel@citrix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1379016042-22510-2-git-send-email-david.vrabel@citrix.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: David Vrabel Cc: Simon Horman , kexec@lists.infradead.org, xen-devel@lists.xen.org On Thu, Sep 12, 2013 at 09:00:38PM +0100, David Vrabel wrote: > From: David Vrabel > > elf_rel_set_symbol() fails if the symbol is in the .bss section. > > Signed-off-by: David Vrabel > --- > purgatory/arch/i386/console-x86.c | 6 +++--- > purgatory/arch/i386/crashdump_backup.c | 8 +++++--- > purgatory/arch/x86_64/purgatory-x86_64.c | 6 +++--- > purgatory/include/purgatory.h | 4 ++++ > purgatory/purgatory.c | 4 ++-- > 5 files changed, 17 insertions(+), 11 deletions(-) > > diff --git a/purgatory/arch/i386/console-x86.c b/purgatory/arch/i386/console-x86.c > index 9773573..40a734b 100644 > --- a/purgatory/arch/i386/console-x86.c > +++ b/purgatory/arch/i386/console-x86.c > @@ -55,9 +55,9 @@ static void putchar_vga(int ch) > */ > > /* Base Address */ > -uint8_t console_serial = 0; > -uint16_t serial_base = 0x3f8; /* TTYS0 */ > -uint32_t serial_baud = 0; > +uint8_t console_serial __data = 0; > +uint16_t serial_base __data = 0x3f8; /* TTYS0 */ > +uint32_t serial_baud __data = 0; Hmmm... I do not know why we need this patch. I can build kexec-tools in my env without it. I suppose that most of people can too. Could you check what is wrong with your build system? Daniel _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec