Re: [PATCH 1/2] kexec: Fix return value build warnings

[Simon Horman <horms@verge.net.au>]

On Thu, Oct 03, 2013 at 08:19:34PM +0000, Geoff Levand wrote:
> Add a local variable 'result' to the putnode() routine of
> ds2dt and use it to hold return values of calls to read().
> 
> Fixes build warnings like these:
> 
>   kexec/fs2dt.c: warning: ignoring return value of ‘read’

Thanks, applied.

> 
> Signed-off-by: Geoff Levand <geoff@infradead.org> for Huawei, Linaro
> ---
>  kexec/fs2dt.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kexec/fs2dt.c b/kexec/fs2dt.c
> index 1f5b0cf..98d6cb4 100644
> --- a/kexec/fs2dt.c
> +++ b/kexec/fs2dt.c
> @@ -555,6 +555,7 @@ static void putnode(void)
>  	/* Add cmdline to the second kernel.  Check to see if the new
>  	 * cmdline has a root=.  If not, use the old root= cmdline.  */
>  	if (!strcmp(basename,"chosen/")) {
> +		size_t result;
>  		size_t cmd_len = 0;
>  		char *param = NULL;
>  		char filename[MAXPATH];
> @@ -636,7 +637,7 @@ static void putnode(void)
>  			close(fd);
>  			goto no_debug;
>  		}
> -		read(fd, buff, statbuf.st_size);
> +		result = read(fd, buff, statbuf.st_size);
>  		close(fd);
>  		strncpy(filename, "/proc/device-tree/", MAXPATH);
>  		strncat(filename, buff, MAXPATH);
> @@ -659,7 +660,7 @@ static void putnode(void)
>  			close(fd);
>  			goto no_debug;
>  		}
> -		read(fd, buff, statbuf.st_size);
> +		result = read(fd, buff, statbuf.st_size);
>  		if (!strcmp(buff, "hvterm1") || !strcmp(buff, "hvterm-protocol"))
>  			my_debug = 1;
>  		close(fd);
> -- 
> 1.8.1.2
> 
> 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec