Re: [patch 2/4] remove extra acpi_rsdp command line for efi

Matthew Garrett
2013-10-28T10:13:23Z

On Mon, Oct 28, 2013 at 05:54:59PM +0800, Dave Young wrote:
> Hi,
> Thanks for review.
>
> On 10/28/13 at 09:42am, Matthew Garrett wrote:
> > On Sun, Oct 27, 2013 at 12:04:39PM +0800, dyoung@redhat.com wrote:
> > > Removing code to pass acpi_rsdp because this
> > > patch series will support efi runtime, it's not
> > > necessary any more. EFI initialization code will
> > > take the functionality.
> >
> > Won't this break kexec of old kernels that don't have the new UEFI setup
> > code?
>
> For old kernels the efi setup_data esdata will be NULL, it wil switch to
> old logic. Also for old kernel user need to pass acpi_rsdp in cmdline

Right, but previously acpi_rsdp was passed automatically and now it
won't be?

--
Matthew Garrett | mjg59@srcf.ucam.org