From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from cavan.codon.org.uk ([2a00:1098:0:80:1000:c:0:1]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vajp4-0000e3-8Z for kexec@lists.infradead.org; Mon, 28 Oct 2013 10:13:23 +0000 Date: Mon, 28 Oct 2013 10:12:56 +0000 From: Matthew Garrett Subject: Re: [patch 2/4] remove extra acpi_rsdp command line for efi Message-ID: <20131028101256.GA3226@srcf.ucam.org> References: <20131027040437.600278368@dhcp-16-126.nay.redhat.com> <20131027041231.024036396@dhcp-16-126.nay.redhat.com> <20131028094223.GA2335@srcf.ucam.org> <20131028095459.GE25527@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131028095459.GE25527@dhcp-16-126.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: kexec@lists.infradead.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, kexec@lists.fedoraproject.org, ebiederm@xmission.com, hpa@zytor.com, bp@alien8.de, vgoyal@redhat.com On Mon, Oct 28, 2013 at 05:54:59PM +0800, Dave Young wrote: > Hi, > Thanks for review. > > On 10/28/13 at 09:42am, Matthew Garrett wrote: > > On Sun, Oct 27, 2013 at 12:04:39PM +0800, dyoung@redhat.com wrote: > > > Removing code to pass acpi_rsdp because this > > > patch series will support efi runtime, it's not > > > necessary any more. EFI initialization code will > > > take the functionality. > > > > Won't this break kexec of old kernels that don't have the new UEFI setup > > code? > > For old kernels the efi setup_data esdata will be NULL, it wil switch to > old logic. Also for old kernel user need to pass acpi_rsdp in cmdline Right, but previously acpi_rsdp was passed automatically and now it won't be? -- Matthew Garrett | mjg59@srcf.ucam.org _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec