Re: [patch 4/4] Passing efi related data via setup_data

Dave Young
2013-10-28T03:03:42Z

On 10/28/13 at 09:12am, Dave Young wrote:
> > > + size = nr_maps * sizeof(struct efi_mem_descriptor) + sizeof(struct efi_setup_data);
> > > + sd = malloc(sizeof(struct setup_data) + size);
> > > + if (!sd) {
> > > + free(esd);
> > > + return;
> > > + }
> >
> > This function appears to leak sd.
>
> Will fix

sd will be passed to add_buffer, it should be freed after kexec_load,
is it really necessary, or I misunderstand something?

>
> --
> Thanks
> Dave