From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from kirsty.vergenet.net ([202.4.237.240]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vc2fS-0005pp-Ug for kexec@lists.infradead.org; Fri, 01 Nov 2013 00:32:51 +0000 Date: Fri, 1 Nov 2013 09:32:26 +0900 From: Simon Horman Subject: Re: [PATCH v2] vmcore-dmesg: Understand >= v3.11-rc4 dmesg Message-ID: <20131101003226.GI6818@verge.net.au> References: <20130919143815.GA4487@dhcp-16-126.nay.redhat.com> <1379602186-13617-1-git-send-email-lkundrak@v3.sk> <20131030031253.GD20932@dhcp16-109.nay.redhat.com> <1383152798.31813.2.camel@odvarok> <20131031053808.GA7611@dhcp16-109.nay.redhat.com> <20131031062026.GX1603@verge.net.au> <52728878.2080302@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <52728878.2080302@linaro.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Taras Kondratiuk Cc: kexec@lists.infradead.org, Lubomir Rintel , Vivek Goyal , Joe Perches , Dave Young , WANG Chao On Thu, Oct 31, 2013 at 09:42:32AM -0700, Taras Kondratiuk wrote: > On 10/30/2013 11:20 PM, Simon Horman wrote: > > On Thu, Oct 31, 2013 at 01:38:08PM +0800, WANG Chao wrote: > >> On 10/30/13 at 06:06pm, Lubomir Rintel wrote: > >>> Hi, > >>> > >>> On Wed, 2013-10-30 at 11:12 +0800, WANG Chao wrote: > >>>> On 09/19/13 at 04:49pm, Lubomir Rintel wrote: > >>>>> Symbol name changed with the following commit: > >>>>> 62e32ac printk: rename struct log to struct printk_log > >>> ... > >>>> vmcore-dmesg is really broken here since 3.11 kernel is released. Are > >>>> you going to send an update v3 to address the comments to v2 from Vivek, > >>>> Joe and Dave > >>> > >>> I'm not really sure. I thought the suggestions were concerning the Linux > >>> kernel tree, not kexec-tools tree. I might be wrong though, but I'd need > >>> the suggestions to be a bit more specific for me to understand. > >> > >> That wouldn't be your concern any more. I think your patch is fine. > >> Thank you for fix. > >> > >> Hi Simon, > >> > >> Will you pick up this patch? Vivek and Dave has acked this patch. > >> And also this patch works for me. > > > > Sure. Please repost it with the Acks. > > I have concerns about this patch. > There were a lot of hardcoded lenght values in the original code. > Now there are twice as much and we need to keep adding hardcoded > values if any additional parameter should be read of renamed. > > Please eveluate this patch [1]. It should remove both: > hardcoded values and duplicated reading for two buffer names. > > [1] http://permalink.gmane.org/gmane.linux.kernel.kexec/9522 Please repost the patch. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec