From: Matt Fleming <matt@console-pimps.org>
To: dyoung@redhat.com
Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com, horms@verge.net.au,
bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com,
vgoyal@redhat.com
Subject: Re: [patch 7/7 v2] x86: add xloadflags bit for efi runtime support on kexec
Date: Wed, 13 Nov 2013 15:50:37 +0000 [thread overview]
Message-ID: <20131113155037.GE17248@console-pimps.org> (raw)
In-Reply-To: <20131105082719.416282009@dhcp-16-126.nay.redhat.com>
On Tue, 05 Nov, at 04:20:14PM, dyoung@redhat.com wrote:
> Old kexec-tools can not load new kernel. The reason is previously kexec-tools
> do not fill efi_info in x86 setup header thus efi init fail and switch
> to noefi boot. In new kexec-tools it will by default fill efi_info and
> pass other efi required infomation to 2nd kernel so kexec kernel efi
> initialization will success finally.
>
> To prevent from breaking userspace, add a new xloadflags bit so kexec-tools
> will check the flag and switch to old logic.
>
> Signed-off-by: Dave Young <dyoung@redhat.com>
> ---
> arch/x86/boot/header.S | 9 ++++++++-
> arch/x86/include/uapi/asm/bootparam.h | 1 +
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> --- linux-2.6.orig/arch/x86/boot/header.S
> +++ linux-2.6/arch/x86/boot/header.S
> @@ -391,7 +391,14 @@ xloadflags:
> #else
> # define XLF23 0
> #endif
> - .word XLF0 | XLF1 | XLF23
> +
> +#if defined(CONFIG_X86_64) && defined(CONFIG_EFI)
&& defined(CONFIG_KEXEC) ?
> +# define XLF4 XLF_EFI_KEXEC
> +#else
> +# define XLF4 0
> +#endif
> +
--
Matt Fleming, Intel Open Source Technology Center
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-11-13 15:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 8:20 [patch 0/7 v2] kexec kernel efi runtime support dyoung
2013-11-05 8:20 ` [patch 1/7 v2] Add function efi_remap_region for remapping to saved virt address dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:38 ` Dave Young
2013-11-15 23:02 ` Toshi Kani
2013-11-18 2:09 ` Dave Young
2013-11-18 9:37 ` Dave Young
2013-11-05 8:20 ` [patch 2/7 v2] x86 efi: reserve boot service fix dyoung
2013-11-15 23:10 ` Toshi Kani
2013-11-05 8:20 ` [patch 3/7 v2] Cleanup efi_enter_virtual_mode function dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:39 ` Dave Young
2013-11-15 23:21 ` Toshi Kani
2013-11-18 2:08 ` Dave Young
2013-11-05 8:20 ` [patch 4/7 v2] export more efi table variable to sysfs dyoung
2013-11-12 0:40 ` Greg KH
2013-11-12 8:19 ` Dave Young
2013-11-12 8:24 ` Dave Young
2013-11-12 8:31 ` Greg KH
2013-11-05 8:20 ` [patch 5/7 v2] export efi runtime memory mapping " dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:50 ` Dave Young
2013-11-18 2:16 ` Dave Young
2013-11-19 12:18 ` Matt Fleming
2013-11-05 8:20 ` [patch 6/7 v2] passing kexec necessary efi data via setup_data dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:52 ` Dave Young
2013-11-05 8:20 ` [patch 7/7 v2] x86: add xloadflags bit for efi runtime support on kexec dyoung
2013-11-13 15:50 ` Matt Fleming [this message]
2013-11-14 1:53 ` Dave Young
2013-11-13 16:20 ` H. Peter Anvin
2013-11-14 1:36 ` Dave Young
2013-11-05 14:40 ` [patch 0/7 v2] kexec kernel efi runtime support Borislav Petkov
2013-11-08 14:31 ` Matt Fleming
2013-11-09 3:57 ` Dave Young
2013-11-09 5:01 ` H. Peter Anvin
2013-11-11 2:13 ` Dave Young
2013-11-11 2:21 ` H. Peter Anvin
2013-11-11 2:47 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113155037.GE17248@console-pimps.org \
--to=matt@console-pimps.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox