Re: [PATCH v2] makedumpfile: add parameters to update_cyclic_region

[Baoquan He <bhe@redhat.com>]

On 11/26/13 at 05:50pm, HATAYAMA Daisuke wrote:
> (2013/11/26 16:57), Baoquan He wrote:
> >On 11/26/13 at 02:50pm, HATAYAMA Daisuke wrote:
> >>(2013/11/26 11:52), Baoquan He wrote:
> >>>On 11/25/13 at 01:33pm, HATAYAMA Daisuke wrote:
> >>>>(2013/11/25 11:31), Baoquan He wrote:
> >
> >>
> >>
> >>BTW, I could successfully clean up the code in this way in kdump-compressed code,
> >>but I couldn't do that in the code from ELF to ELF... So I have yet to post
> >>such clean up patch.
> >
> >This is cool, cleanup like this would make code clearer. Let's wait your
> >clean up patch, I can help review and test.
> >
> 
> For that, you need to pass a part with the currnet cycle to __exclude_unnecessary_pages(),
> not a whole (mmd->pfn_start, mmd->pfn_end). There might be similar part that needs fix,
> but sorry I don't have good memory...
> 
> int
> exclude_unnecessary_pages_cyclic(void)
> {
> <cut>
>                         if (mmd->pfn_end >= info->cyclic_start_pfn &&
>                             mmd->pfn_start <= info->cyclic_end_pfn) {
>                                 if (!__exclude_unnecessary_pages(mmd->mem_map,
>                                                                  mmd->pfn_start, mmd->pfn_end))
>                                         return FALSE;
>                         }
> 
> For ELF-to-ELF code, unfortunately, I gave up in the middle of source code reading.
> At lesst, if I remember correctly, I think the code relied on the current
> update_mmap_range() implementation. It might be hard to clean up there in a natural way.

Yeah, understood. How about I post a patch based on my v1,
then you can do the cleanup work of elf part deliberately.


> 
> -- 
> Thanks.
> HATAYAMA, Daisuke
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec